You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2009/09/02 20:54:33 UTC
[jira] Created: (LUCENE-1887) o.a.l.messages should be
moved/renamed
o.a.l.messages should be moved/renamed
--------------------------------------
Key: LUCENE-1887
URL: https://issues.apache.org/jira/browse/LUCENE-1887
Project: Lucene - Java
Issue Type: Improvement
Reporter: Hoss Man
Priority: Minor
Fix For: 2.9
contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luis Alves updated LUCENE-1887:
-------------------------------
Attachment: lucene-1877-new.patch
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753364#action_12753364 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
I created a patch it should apply clean in main.
I'm looking at Robert's patch, only notice he posted after I created the patch :)
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1887) o.a.l.messages should be
moved to it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753190#action_12753190 ]
Luis Alves edited comment on LUCENE-1887 at 9/9/09 11:06 AM:
-------------------------------------------------------------
{quote}
The window is closing on this one - the current code is 1.5 - do we want to convert to 1.4 and move to core? Move to messages contrib? Else it will remain the same.
{quote}
+1 I am OK with making the o.a.l.messages.* 1.4 compatible and move it to core in 2.9.
NOTE: We also would have to move the testcases for the o.a.l.messsages.*
was (Author: lafa):
{quote}
The window is closing on this one - the current code is 1.5 - do we want to convert to 1.4 and move to core? Move to messages contrib? Else it will remain the same.
{quote}
+1 I am OK with making the o.a.l.messages.* 1.4 compatible and move it to core in 2.9.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753381#action_12753381 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
I agree with you on the compatibility, I'll remove the deprecated from the getLocalizedMessage method on
NLS class and submit again
{code}
public static String getLocalizedMessage(String key, Locale locale, Object[] args)
{code}
I just think it is ugly having to create a Object array for every call to the Message classes.
See Example below.
Original or with my patch
{code}
throw new ParseException(new MessageImpl(QueryParserMessages.INVALID_SYNTAX_ESCAPE_NONE_HEX_UNICODE, c));
{code}
Example using your patch:
{code}
throw new ParseException(new MessageImpl(QueryParserMessages.INVALID_SYNTAX_ESCAPE_NONE_HEX_UNICODE, new Object[]{c}));
{code}
This is not a big thing for me.
If we don't care that the users of these classes in 2.9 are required to create the object arrays for most method calls, then
I am totally ok with your patch.
We can clean the new QueryParser code, of those object arrays in 3.0.
Robert or Mark pick any of the patches, they both look good to me.
Need to go home, I'll check the issue later.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
core
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753710#action_12753710 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
I was not able to read the thread late yesterday :(.
But great work, it's good to see the message classes in main.
Even if is not my patch I like it :)
Thanks guys
> o.a.l.messages should be moved to core
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887-javadocs-all.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be
moved/renamed
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated LUCENE-1887:
-----------------------------
Fix Version/s: (was: 2.9)
bq. These classes have not relation with the queryparser code, the queryparser only uses it.
that seems like a pretty strong argument to promote it into it's own contrib ... no other contrib is going to start depending on queryParser just to get access to a messages class -- And if we wait until 3.x to move it to it's own contrib, we make a lot of headaches for any users who start(ed) using the queryParser contrib in 2.9, because all of hte sudden their code will stop working at runtime because the classes can't be found.
(it's an easy problem to fix: tell them to use the new jar as well, but it reflects badly on the project when people encounter annoyances like that when upgrading)
That said: i'm not going to argue that hard if no more closely involved in the contrib thinks it's worth moving .. removing 2.9 fix-for.
> o.a.l.messages should be moved/renamed
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
> I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753373#action_12753373 ]
Robert Muir commented on LUCENE-1887:
-------------------------------------
Luis, yeah, the difference is your patch has the deprecated methods.
in my patch there are no deprecated methods, it uses Object[] instead of varargs.
but these are compatible to jdk1.5: http://java.sun.com/j2se/1.5.0/docs/guide/language/varargs.html
so you can change it to ... (varargs) and it will be backwards compatible, without any deprecation.
then at your leisure, once on jdk1.5, you can remove the new Object[] {}, it will be autoboxed.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1887:
----------------------------------
Attachment: LUCENE-1887-javadocs-all.patch
> o.a.l.messages should be moved to core
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887-javadocs-all.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753190#action_12753190 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
{quote}
The window is closing on this one - the current code is 1.5 - do we want to convert to 1.4 and move to core? Move to messages contrib? Else it will remain the same.
{quote}
+1 I am OK with making the o.a.l.messages.* 1.4 compatible and move it to core in 2.9.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1887) o.a.l.messages should be
moved to it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753181#action_12753181 ]
Luis Alves edited comment on LUCENE-1887 at 9/9/09 11:04 AM:
-------------------------------------------------------------
The original idea is to have messages and the new queryparser moved into core on 3.0. But this was discussed in the mailing list and the community thinks it's better to give it some more time for the API's on the new QP to get stable and allow more time for review of the new queryparser.
I think there is an understanding to move the new QueryParser to core, when 3.1 is released.
When the new messages and the queryparser is moved to core, it will be more usable. If we keep it on contrib, in my opinion we should leave it as is for release 2.9 and 3.0
We should re-look at this issue when 3.0 is done, by moving message and the queryparser to core.
was (Author: lafa):
The original idea is to have messages and the new queryparser moved into main on 3.0. But this was discussed in the mailing list and the community thinks it's better to give it some more time for the API's to get stable and allow more time for review of the new queryparser.
I think there is an understanding to move the new QueryParser to main, when 3.1 is released.
When the new messages and the queryparser is moved to main, it will be more usable. In my opinion we should leave it as is for release 2.9 and 3.0, and look at this issue when 3.0 is done, by moving messages to main and probably the queryparser to main.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753390#action_12753390 ]
Robert Muir commented on LUCENE-1887:
-------------------------------------
bq. I agree on the consistency front - Robert, I'll go with yours it looks - is it ready, or need to make any last changes?
i think it is ready, all the tests pass.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753367#action_12753367 ]
Mark Miller commented on LUCENE-1887:
-------------------------------------
Okay - just let me know which to go with
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1887) o.a.l.messages should be
moved to it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753369#action_12753369 ]
Robert Muir edited comment on LUCENE-1887 at 9/9/09 6:38 PM:
-------------------------------------------------------------
Luis the only real difference from yours is i used Object[] for the varags like the 1.4 MessageFormat
do we really need to deprecate the Object[] when it becomes ... in 1.5? sun didnt.
I am java5 brain-dead :) this is documented to be compatible: http://java.sun.com/j2se/1.5.0/docs/guide/language/varargs.html
was (Author: rcmuir):
Luis the only real difference from yours is i used Object[] for the varags like the 1.4 MessageFormat
do we really need to deprecate the Object[] when it becomes ... in 1.5? sun didnt.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1887) o.a.l.messages should be moved to
core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-1887.
-----------------------------------
Resolution: Fixed
Revision: 813268
> o.a.l.messages should be moved to core
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887-javadocs-all.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753386#action_12753386 ]
Robert Muir commented on LUCENE-1887:
-------------------------------------
bq. I just think it is ugly having to create a Object array for every call to the Message classes.
my reasoning here was that this is how MessageFormat works in java 1.4, since this is a wrapper around MessageFormat, it is consistent with MessageFormat.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Adriano Crestani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753355#action_12753355 ]
Adriano Crestani commented on LUCENE-1887:
------------------------------------------
Hi Mark,
{quote}
Can you do it right now? So I can do rc4 tonight?
{quote}
Who is "you"? And do what, move to core or move to a new contrib project?
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Reopened: (LUCENE-1887) o.a.l.messages should be moved to
core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler reopened LUCENE-1887:
-----------------------------------
Assignee: Mark Miller
One small thing:
The javadocs-all still list the messages package in queryparser contrib. I will attach a patch.
> o.a.l.messages should be moved to core
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be
moved/renamed
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751997#action_12751997 ]
Mark Miller commented on LUCENE-1887:
-------------------------------------
The window is closing on this one - the current code is 1.5 - do we want to convert to 1.4 and move to core? Move to messages contrib? Else it will remain the same.
> o.a.l.messages should be moved/renamed
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Fix For: 2.9
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
> I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
core
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-1887:
----------------------------------
Fix Version/s: 2.9
> o.a.l.messages should be moved to core
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 2.9
>
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887-javadocs-all.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753371#action_12753371 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
I looked at Robert's patch it is very similar to mine,
but Robert changed the testcases and the queryparser code to use a new method signature.
My patch added more utility methods (deprecated) on NLS and MessageImpl and does not require any changes the QP and the tescases.
I prefer my approach because it will be compatible to jdk1.5, once we remove the utility methods from these classes and revert back to the jdk 1.5 syntax in 3.0.
Robert please take a look at my patch and see if you like it.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-1887:
--------------------------------
Attachment: LUCENE-1887.patch
first do:
{noformat}
svn move contrib/queryparser/src/java/org/apache/lucene/messages src/java/org/apache/lucene
svn move contrib/queryparser/src/test/org/apache/lucene/messages src/test/org/apache/lucene
{noformat}
then apply patch
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller resolved LUCENE-1887.
---------------------------------
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [New])
Thanks a million guys.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753389#action_12753389 ]
Mark Miller commented on LUCENE-1887:
-------------------------------------
I agree on the consistency front - Robert, I'll go with yours it looks - is it ready, or need to make any last changes?
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be
moved/renamed
Posted by "Adriano Crestani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750621#action_12750621 ]
Adriano Crestani commented on LUCENE-1887:
------------------------------------------
These classes have not relation with the queryparser code, the queryparser only uses it. Maybe in future other parts of lucene may start using it. So I vote to leave it outside queryParser package for now, and when other parts of lucene start using it, we can think about moving it to core.
> o.a.l.messages should be moved/renamed
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Fix For: 2.9
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
> I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luis Alves updated LUCENE-1887:
-------------------------------
Attachment: lucene-1877-new-v2.patch
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753181#action_12753181 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
The original idea is to have messages and the new queryparser moved into main on 3.0. But this was discussed in the mailing list and the community thinks it's better to give it some more time for the API's to get stable and allow more time for review of the new queryparser.
I think there is an understanding to move the new QueryParser to main, when 3.1 is released.
When the new messages and the queryparser is moved to main, it will be more usable. In my opinion we should leave it as is for release 2.9 and 3.0, and look at this issue when 3.0 is done, by moving messages to main and probably the queryparser to main.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated LUCENE-1887:
-----------------------------
Component/s: contrib/*
Description:
contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
*EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
was:
contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
Summary: o.a.l.messages should be moved to it's own contrib (was: o.a.l.messages should be moved/renamed)
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753384#action_12753384 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
I updated the my patch to remove the deprecated from
{code}
public static String getLocalizedMessage(String key, Locale locale, Object[] args)
{code}
I'm also ok with Robert patch, they are almost identical.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753369#action_12753369 ]
Robert Muir commented on LUCENE-1887:
-------------------------------------
Luis the only real difference from yours is i used Object[] for the varags like the 1.4 MessageFormat
do we really need to deprecate the Object[] when it becomes ... in 1.5? sun didnt.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753387#action_12753387 ]
Robert Muir commented on LUCENE-1887:
-------------------------------------
Luis, if we go with your patch, I think we should add MessageImpl(Object[]) constructor back , not deprecated, to be changed to MessageImpl(Object ...) in 1.5
otherwise it is limited to 3 arguments :)
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1887) o.a.l.messages should be moved to
core
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated LUCENE-1887:
--------------------------------
Summary: o.a.l.messages should be moved to core (was: o.a.l.messages should be moved to it's own contrib)
> o.a.l.messages should be moved to core
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
> Attachments: lucene-1877-new-v2.patch, lucene-1877-new.patch, LUCENE-1887.patch
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753329#action_12753329 ]
Mark Miller commented on LUCENE-1887:
-------------------------------------
Can you do it right now? So I can do rc4 tonight?
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be
moved/renamed
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750706#action_12750706 ]
Luis Alves commented on LUCENE-1887:
------------------------------------
+1 to keep outside parser.
These small utility classes are designed to handle Message translation, for the queryparser but can be used by any other component in lucene that wants to display translated resources.
> o.a.l.messages should be moved/renamed
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Fix For: 2.9
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
> I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be
moved/renamed
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750712#action_12750712 ]
Robert Muir commented on LUCENE-1887:
-------------------------------------
I agree it would be nice to have a package for localized messages in general.
In the future this leaves open the door for localization of other parts of lucene.
since it uses MessageFormat etc, I think it would be very reusable.
> o.a.l.messages should be moved/renamed
> --------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Fix For: 2.9
>
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> Alternately: if the code isn't super reusable, the package name should probably be changed to be a subpackage of org.apache.lucene.queryParser ... it tends to be very confusing when all of the code in a contrib doesn't fall into a clear organizational namespace.
> I've marked this issue for 2.9 so we at least think about it prior to release ... it is a brand new public API, so this is out best chance to change it if we want ... but it is by no means a blocker for 2.9
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1887) o.a.l.messages should be moved to
it's own contrib
Posted by "Adriano Crestani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753328#action_12753328 ]
Adriano Crestani commented on LUCENE-1887:
------------------------------------------
+1 to make it 1.4 compatible and move it to core in 2.9
+1 to move it to another contrib project called, e.g. "messages"
I think Hoss made his point about not leaving this code in queryparser contrib project and I agree.
> o.a.l.messages should be moved to it's own contrib
> --------------------------------------------------
>
> Key: LUCENE-1887
> URL: https://issues.apache.org/jira/browse/LUCENE-1887
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Hoss Man
> Priority: Minor
>
> contrib/queryParser contains an org.apache.lucene.messages package containing some generallized code that (claims in it's javadocs) is not specific to the queryParser.
> If this is truely general purpose code, it should probably be moved out of hte queryParser contrib -- either into it's own contrib, or into the core (it's very small)
> *EDIT:* alternate suggestion to rename package to fall under the o.a.l.queryParser namespace retracted due to comments in favor of (eventually) promoting to it's own contrib
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org