You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/07/13 22:56:15 UTC

Re: svn commit: r1146306 - /subversion/branches/1.7.x/STATUS

On Wed, Jul 13, 2011 at 15:44,  <da...@apache.org> wrote:
> Author: danielsh
> Date: Wed Jul 13 19:44:57 2011
> New Revision: 1146306
>
> URL: http://svn.apache.org/viewvc?rev=1146306&view=rev
> Log:
> Nominate r1146222.
>
> I've checked the rest of fs_fs.c, and there are no other similar problems,
> assuming that apr_psprintf("%s", NULL) is safe and svn_fs_fs__id_unparse()
> isn't called on NULL id's; but I have not verified either of those
> assumptions yet.

apr/strings/apr_snprintf.c::apr_vformatter() ... look for the case
's', and note that it tests for NULL. If so, then it uses S_NULL for
the string, which is defined as "(null)".

Cheers,
-g