[GitHub] [pinot] jadami10 commented on a change in pull request #7892: return 503 response from health check on shut down

[GitBox <gi...@apache.org>]

jadami10 commented on a change in pull request #7892:
URL: https://github.com/apache/pinot/pull/7892#discussion_r767201254



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/service/PinotServiceManager.java
##########
@@ -199,6 +199,7 @@ public boolean stopPinotInstance(ServiceStartable instance) {
       ServiceRole role = instance.getServiceRole();
       String instanceId = instance.getInstanceId();
       LOGGER.info("Trying to stop Pinot [{}] Instance [{}] ...", role, instanceId);
+      ServiceStatus.setServiceStatusCallback(instanceId, new ServiceStatus.ShuttingDownServiceStatusCallback());
       instance.stop();

Review comment:
       I could use some help understanding the impact of doing this. On our end (and for most people) I assume this is desired so load balancers actually stop sending queries to these machines while they're going down. But will this affect pinot internally somehow? Should this be a new configuration? Should it be limited to brokers?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org