You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/16 02:19:03 UTC

[GitHub] [incubator-seatunnel] BenJFan opened a new issue, #1884: [Feature][Core] Plugin-Mapping load ignore case

BenJFan opened a new issue, #1884:
URL: https://github.com/apache/incubator-seatunnel/issues/1884

   ### Search before asking
   
   - [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
   
   
   ### Description
   
   At dev now, we use `plugin-mapping.properties` to find plugin we should load. The logic is: Parse config, then get source/sink plugin name. use this name to find plugin-mapping key in `plugin-mapping.properties`. The value will be plugin jar prefix name. Finally the jar load success.
   The problem is plugin name in config not support ignore case (older version supported). We should support any case plugin name can map to plugin-mapping key. 
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on issue #1884: [Feature][Core] Plugin-Mapping load ignore case

Posted by GitBox <gi...@apache.org>.
BenJFan commented on issue #1884:
URL: https://github.com/apache/incubator-seatunnel/issues/1884#issuecomment-1127145827

   @ruanwenjun Hi, I think this is a good first issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun closed issue #1884: [Feature][Core] Plugin-Mapping load ignore case

Posted by GitBox <gi...@apache.org>.
ruanwenjun closed issue #1884: [Feature][Core] Plugin-Mapping load ignore case
URL: https://github.com/apache/incubator-seatunnel/issues/1884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on issue #1884: [Feature][Core] Plugin-Mapping load ignore case

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #1884:
URL: https://github.com/apache/incubator-seatunnel/issues/1884#issuecomment-1128488233

   > @ruanwenjun Hi, I think this is a good first issue.
   
   Do you mean the upper case/lower case mapping to the plugin jar? In fact, I have support this in #1881. But #1881 will not be released in next version. 
   
   I add a help wanted label, we need to finish this issue before our next release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org