[GitHub] [hive] odraese commented on a change in pull request #699: HIVE-21908: LlapDaemon node status should be reflected in the metrics

[GitBox <gi...@apache.org>]

odraese commented on a change in pull request #699: HIVE-21908: LlapDaemon node status should be reflected in the metrics
URL: https://github.com/apache/hive/pull/699#discussion_r300091435
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorInfo.java
 ##########
 @@ -64,6 +64,8 @@
   ExecutorFallOffNumCompletedFragments("Number of completed fragments w.r.t falloff values"),
   AverageQueueTime("Average queue time for tasks"),
   AverageResponseTime("Average response time for successful tasks"),
+  NumExecutorsEnabled("The number of executor threads enabled"),
+  WaitQueueSizeEnabled("Size of wait queue enabled"),
 
 Review comment:
   Not sure of "enabled" is right in the context of a wait queue. It would just remove "enabled".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org