[GitHub] nitin-maharana commented on a change in pull request #2494: [CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file

[GitBox <gi...@apache.org>]

nitin-maharana commented on a change in pull request #2494: [CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file
URL: https://github.com/apache/cloudstack/pull/2494#discussion_r175302465
 
 

 ##########
 File path: ui/scripts/vpc.js
 ##########
 @@ -15,6 +15,53 @@
 // specific language governing permissions and limitations
 // under the License.
 (function($, cloudStack) {
+    var isNumeric = function (n) {
+        return !isNaN(parseFloat(n));
+    };
+    var createSafeCsvValue = function(value){
+        if(value){
+            return '"' + value + '"';
 
 Review comment:
   Hi @rafaelweingartner, Thanks for adding this functionality.
   Here, Will the input look like this: ("a","b","c"...) or (a,b,c...). The variable csv in generateCsvForAclRules function converts to string when it is initialized (concatenated with a comma string).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services