You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/07 12:58:47 UTC
[GitHub] [airflow] rafagsiqueira opened a new pull request, #24288: Update index.rst
rafagsiqueira opened a new pull request, #24288:
URL: https://github.com/apache/airflow/pull/24288
This also applies when using fluxCD for gitops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rafagsiqueira commented on pull request #24288: Add Flux to chart gitops docs
Posted by GitBox <gi...@apache.org>.
rafagsiqueira commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1154526473
Hahahhaa! @jedcunningham thanks for the encouragement! Such a huge contribution I made to the project. Hahahhaha! I wish I had time to actually contribute. I love your project and I am really grateful to everyone who dedicate their time to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1148636304
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1148721057
Added missing "----" to prevent checks from failing @rafagsiqueira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #24288:
URL: https://github.com/apache/airflow/pull/24288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rafagsiqueira commented on pull request #24288: Add Flux to chart gitops docs
Posted by GitBox <gi...@apache.org>.
rafagsiqueira commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1154533619
It did take me at least a day to figure out why the migration job wasnโt running, so I hope it does help whoever comes after me. Flux is also the technology behind Azure arc-enabled clusters, so this might benefit a few people. ๐ป
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24288:
URL: https://github.com/apache/airflow/pull/24288#discussion_r891272196
##########
docs/helm-chart/index.rst:
##########
@@ -119,10 +119,10 @@ To uninstall/delete the ``airflow`` deployment:
The command removes all the Kubernetes components associated with the chart and deletes the release.
-Installing the Chart with ArgoCD
+Installing the Chart with ArgoCD or FluxCD
--------------------------------
Review Comment:
```suggestion
------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1148722322
FYI It works for RST were underlines are LONGER than text they underline, but RST breaks when they are SHORTER :exploding_head:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #24288:
URL: https://github.com/apache/airflow/pull/24288#discussion_r896082690
##########
docs/helm-chart/index.rst:
##########
@@ -119,10 +119,10 @@ To uninstall/delete the ``airflow`` deployment:
The command removes all the Kubernetes components associated with the chart and deletes the release.
-Installing the Chart with ArgoCD
---------------------------------
+Installing the Chart with ArgoCD or FluxCD
+------------------------------------------
-When installing the chart using ArgoCD, you MUST set the two following values, or your application
+When installing the chart using ArgoCD or FluxCD, you MUST set the two following values, or your application
Review Comment:
```suggestion
When installing the chart using Argo CD or Flux, you MUST set the two following values, or your application
```
##########
docs/helm-chart/index.rst:
##########
@@ -119,10 +119,10 @@ To uninstall/delete the ``airflow`` deployment:
The command removes all the Kubernetes components associated with the chart and deletes the release.
-Installing the Chart with ArgoCD
---------------------------------
+Installing the Chart with ArgoCD or FluxCD
+------------------------------------------
Review Comment:
```suggestion
Installing the Chart with Argo CD or Flux
-----------------------------------------
```
Just from looking at their site, they seem to just use "Flux", not "FluxCD"?
Also looks like it should be "Argo CD" instead too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rafagsiqueira commented on a diff in pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
rafagsiqueira commented on code in PR #24288:
URL: https://github.com/apache/airflow/pull/24288#discussion_r896085786
##########
docs/helm-chart/index.rst:
##########
@@ -119,10 +119,10 @@ To uninstall/delete the ``airflow`` deployment:
The command removes all the Kubernetes components associated with the chart and deletes the release.
-Installing the Chart with ArgoCD
---------------------------------
+Installing the Chart with ArgoCD or FluxCD
+------------------------------------------
Review Comment:
Agreed. They used to use FluxCD in the beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1154443778
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #24288: Add Flux to chart gitops docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1154476668
Thanks @rafagsiqueira! Congrats on your first commit ๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24288: Update index.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1154475899
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #24288: Add Flux to chart gitops docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #24288:
URL: https://github.com/apache/airflow/pull/24288#issuecomment-1154531543
Seriously though, a bunch of small contributions like this really does add up over time. Docs are really important for open source communities, and unfortunately the folks super involved are typically the worst ones to write docs because we have a bunch of domain knowledge already. It's hard to "look at it with fresh eyes" if that makes sense.
So yeah, not the most earth shattering contribution, but you still made the chart docs a bit better and we appreciate it ๐บ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org