You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Gary Tully (JIRA)" <ji...@apache.org> on 2010/01/29 19:44:32 UTC
[jira] Resolved: (AMQ-2585) ActiveMQTextMessage.getSize() does not
consider size of properties
[ https://issues.apache.org/activemq/browse/AMQ-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Tully resolved AMQ-2585.
-----------------------------
Resolution: Fixed
Fix Version/s: 5.4.0
Assignee: Gary Tully
thanks for the test case. I made some mods as the override of min message size is only relevant to the broker. The size is calculated on demand for consumers.
committed in r904585
> ActiveMQTextMessage.getSize() does not consider size of properties
> ------------------------------------------------------------------
>
> Key: AMQ-2585
> URL: https://issues.apache.org/activemq/browse/AMQ-2585
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMS client
> Affects Versions: 5.3.0
> Reporter: Magnus Persson
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.4.0
>
> Attachments: ReasonableTextMessageSize.patch
>
>
> Checking the size of a text message only considers the body of a message, not the properties. I think this relates to a typo in the method:
> {noformat}
> public int getSize() {
> if (size == 0 && content == null && text != null) {
> size = getMinimumMessageSize();
> if (marshalledProperties != null) {
> size += marshalledProperties.getLength();
> }
> size = text.length() * 2;
> }
> return super.getSize();
> }
> {noformat}
> This should perhaps be size += text.length() * 2?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.