You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2021/06/27 21:53:13 UTC

[kafka] branch 2.8 updated: KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion (#10922)

This is an automated email from the ASF dual-hosted git repository.

ijuma pushed a commit to branch 2.8
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/2.8 by this push:
     new 9a3351d  KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion (#10922)
9a3351d is described below

commit 9a3351db196e739bc7ec58681781b3f3aa23879b
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Sun Jun 27 14:15:19 2021 -0700

    KAFKA-12790: Remove SslTransportLayerTest.testUnsupportedTlsVersion (#10922)
    
    Support for TLS 1.0/1.1 was disabled in recent versions of Java 8/11
    and all versions of 16 causing this test to fail.
    
    It is possible to make it work by updating the relevant security property,
    but it has to be done before the affected classes are loaded and it can
    not be disabled after that. Given the low value of the test, we remove
    it.
    
    Reviewers: Rajini Sivaram <ra...@googlemail.com>, Luke Chen <sh...@gmail.com>
---
 .../apache/kafka/common/network/SslTransportLayerTest.java  | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java b/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
index 4418713..b177a01 100644
--- a/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java
@@ -632,19 +632,6 @@ public class SslTransportLayerTest {
     }
 
     /**
-     * Tests that connections cannot be made with unsupported TLS versions
-     */
-    @ParameterizedTest
-    @ArgumentsSource(SslTransportLayerArgumentsProvider.class)
-    public void testUnsupportedTLSVersion(Args args) throws Exception {
-        args.sslServerConfigs.put(SslConfigs.SSL_ENABLED_PROTOCOLS_CONFIG, Arrays.asList("TLSv1.2"));
-        server = createEchoServer(args, SecurityProtocol.SSL);
-
-        checkAuthenticationFailed(args, "0", "TLSv1.1");
-        server.verifyAuthenticationMetrics(0, 1);
-    }
-
-    /**
      * Tests that connections cannot be made with unsupported TLS cipher suites
      */
     @ParameterizedTest