You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/05/29 22:46:04 UTC
Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/
-----------------------------------------------------------
Review request for mesos, Xudong Ni and Jiang Yan Xu.
Bugs: MESOS-8340
https://issues.apache.org/jira/browse/MESOS-8340
Repository: mesos
Description
-------
Added MESOS-8340 to the 1.7.x CHANGELOG.
Diffs
-----
CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
Diff: https://reviews.apache.org/r/67365/diff/1/
Testing
-------
Manual inspection of the dev website.
Thanks,
James Peach
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204021
-----------------------------------------------------------
PASS: Mesos patch 67365 was successfully built and tested.
Reviews applied: `['67365']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67365
- Mesos Reviewbot Windows
On May 29, 2018, 3:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 3:46 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/1/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Xudong Ni via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204027
-----------------------------------------------------------
CHANGELOG
Lines 8 (patched)
<https://reviews.apache.org/r/67365/#comment286414>
Need empty line to separate new features
- Xudong Ni
On May 29, 2018, 10:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 10:46 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/1/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On May 30, 2018, 10:56 a.m., Jiang Yan Xu wrote:
> > docs/upgrades.md
> > Lines 445 (patched)
> > <https://reviews.apache.org/r/67365/diff/1/?file=2031690#file2031690line445>
> >
> > Is it TCP specific?
>
> James Peach wrote:
> Yes.
I see and I found the word TCP in code comments. So apps are free to listening on unassigned UDP ports? This is fine but I am just a bit surprised this is the place in the documentation that TCP is mentioned (not in network-ports.md either). Worth clarifying (separately as this RR is about CHANGELOG)?
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204058
-----------------------------------------------------------
On May 30, 2018, 11:57 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 11:57 a.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/2/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by James Peach <jp...@apache.org>.
> On May 30, 2018, 5:56 p.m., Jiang Yan Xu wrote:
> > docs/upgrades.md
> > Lines 445 (patched)
> > <https://reviews.apache.org/r/67365/diff/1/?file=2031690#file2031690line445>
> >
> > Is it TCP specific?
Yes.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204058
-----------------------------------------------------------
On May 30, 2018, 6:57 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 6:57 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/2/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204058
-----------------------------------------------------------
docs/upgrades.md
Lines 445 (patched)
<https://reviews.apache.org/r/67365/#comment286451>
Is it TCP specific?
- Jiang Yan Xu
On May 29, 2018, 3:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 3:46 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/1/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204095
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67365]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 30, 2018, 6:57 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 6:57 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/2/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Xudong Ni via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204067
-----------------------------------------------------------
Ship it!
Ship It!
- Xudong Ni
On May 30, 2018, 6:57 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 6:57 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/2/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204104
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On May 30, 2018, 11:57 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 11:57 a.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/2/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/#review204076
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67365']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67365
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67365/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (117 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1037 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (40 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (731 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (755 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (730 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (755 ms total)
[----------] Global test environment tear-down
[==========] 980 tests from 95 test cases ran. (448206 ms total)
[ PASSED ] 979 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SlaveTest.RestartSlaveRequireExecutorAuthentication
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67365/logs/mesos-tests-stderr.log):
```
I0530 20:33:55.514915 22280 master.cpp:10843] Updating the state of task 1f3da820-3c4b-4547-a163-c8dc456b73c9 of framework f6304a20-7ee4-4c98-ab26-8a8593e9d396-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0530 20:33:55.515866 21840 slave.cpp:3935] Shutting down framework f6304a20-7ee4-4c98-ab26-8a8593e9d396-0000
I0530 20:33:55.515866 21840 slave.cpp:6656] Shutting down executor '1f3da820-3c4b-4547-a163-c8dc456b73c9' of framework f6304a20-7ee4-4c98-ab26-8a8593e9d396-0000 at executor(1)@192.10.1.6:64445
I0530 20:33:55.517881 21840 slave.cpp:929] Agent terminating
W0530 20:33:55.517881 21840 slave.cpp:3931] Ignoring shutdown framework f6304a20-7ee4-4c98-ab26-8a8593e9d396-0000 because it is terminating
I0530 20:33:55.517881 22280 master.cpp:10942] Removing task 1f3da820-3c4b-4547-a163-c8dc456b73c9 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f6304a20-7ee4-4c98-ab26-8a8593e9d396-0000 on agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0 at slave(447)@192.10.1.6:64424 (windows-02.enofukwuI0530 20:33:55.344907 20168 exec.cpp:162] Version: 1.7.0
I0530 20:33:55.370146 15416 exec.cpp:236] Executor registered on agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0
I0530 20:33:55.373888 15644 executor.cpp:178] Received SUBSCRIBED event
I0530 20:33:55.378913 15644 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0530 20:33:55.378913 15644 executor.cpp:178] Received LAUNCH event
I0530 20:33:55.383896 15644 executor.cpp:665] Starting task 1f3da820-3c4b-4547-a163-c8dc456b73c9
I0530 20:33:55.476908 15644 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0530 20:33:55.489912 15644 executor.cpp:678] Forked command at 8512
I0530 20:33:55.517881 20700 exec.cpp:445] Executor asked to shutdown
I0530 20:33:55.517881 14184 executor.cpp:178] Received SHUTDOWN event
I0530 20:33:55.517881 14184 executor.cpp:781] Shutting down
I0530 20:33:55.517881 14184 executor.cpp:894] Sending SIGTERM to process tree at pid 85114ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0530 20:33:55.521878 22280 master.cpp:1293] Agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0 at slave(447)@192.10.1.6:64424 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0530 20:33:55.521878 22280 master.cpp:3303] Disconnecting agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0 at slave(447)@192.10.1.6:64424 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0530 20:33:55.521878 22280 master.cpp:3322] Deactivating agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0 at slave(447)@192.10.1.6:64424 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0530 20:33:55.522878 18764 hierarchical.cpp:344] Removed framework f6304a20-7ee4-4c98-ab26-8a8593e9d396-0000
I0530 20:33:55.522878 14992 containerizer.cpp:2406] Destroying container a65ed251-2618-4c33-9d3f-89c42f91b0ba in RUNNING state
I0530 20:33:55.522878 14992 containerizer.cpp:3020] Transitioning the state of container a65ed251-2618-4c33-9d3f-89c42f91b0ba from RUNNING to DESTROYING
I0530 20:33:55.522878 18764 hierarchical.cpp:766] Agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0 deactivated
I0530 20:33:55.523876 14992 launcher.cpp:156] Asked to destroy container a65ed251-2618-4c33-9d3f-89c42f91b0ba
I0530 20:33:55.581549 22164 containerizer.cpp:2859] Container a65ed251-2618-4c33-9d3f-89c42f91b0ba has exited
I0530 20:33:55.611557 4736 master.cpp:1135] Master terminating
I0530 20:33:55.613553 13272 hierarchical.cpp:609] Removed agent f6304a20-7ee4-4c98-ab26-8a8593e9d396-S0
I0530 20:33:56.036558 16228 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 30, 2018, 6:57 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67365/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 6:57 p.m.)
>
>
> Review request for mesos, Xudong Ni and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-8340 to the 1.7.x CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
> docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
>
>
> Diff: https://reviews.apache.org/r/67365/diff/2/
>
>
> Testing
> -------
>
> Manual inspection of the dev website.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67365/
-----------------------------------------------------------
(Updated May 30, 2018, 6:57 p.m.)
Review request for mesos, Xudong Ni and Jiang Yan Xu.
Bugs: MESOS-8340
https://issues.apache.org/jira/browse/MESOS-8340
Repository: mesos
Description
-------
Added MESOS-8340 to the 1.7.x CHANGELOG.
Diffs (updated)
-----
CHANGELOG 52c7fc3bcd73a0eead2934644f636b85c60e0061
docs/upgrades.md 1a1705cd9c38583c591392dd154d136fce04129d
Diff: https://reviews.apache.org/r/67365/diff/2/
Changes: https://reviews.apache.org/r/67365/diff/1-2/
Testing
-------
Manual inspection of the dev website.
Thanks,
James Peach