You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by aurelienduarte <gi...@git.apache.org> on 2018/11/18 07:56:39 UTC

[GitHub] metron pull request #1271: Updated org.apache.rat from 0.13-SNAPSHOT to 0.13

GitHub user aurelienduarte opened a pull request:

    https://github.com/apache/metron/pull/1271

    Updated org.apache.rat from 0.13-SNAPSHOT to 0.13

    ## Contributor Comments
    [Please place any comments here.  A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aurelienduarte/metron patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1271
    
----
commit 0666f093edbda9da8e73721a39cd310fb017c256
Author: aurelienduarte <an...@...>
Date:   2018-11-18T07:56:07Z

    Updated org.apache.rat from 0.13-SNAPSHOT to 0.13

----


---

[GitHub] metron issue #1271: METRON-1883 Updated org.apache.rat from 0.13-SNAPSHOT to...

Posted by aurelienduarte <gi...@git.apache.org>.
Github user aurelienduarte commented on the issue:

    https://github.com/apache/metron/pull/1271
  
    > mvn -q clean integration-test install 
    Failed, due to an unrelated issue. See summary below.
    
    Tests run: 567, Failures: 1, Errors: 0, Skipped: 2
    
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18:test (unit-tests) on project stellar-common: There are test failures.
    [ERROR]
    [ERROR] Please refer to /Users/aurelienduarte/Google Drive/Research/metron/metron/metron-stellar/stellar-common/target/surefire-reports for the individual test results.
    [ERROR] -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    [ERROR]
    [ERROR] After correcting the problems, you can resume the build with the command
    [ERROR]   mvn <goals> -rf :stellar-common


---

[GitHub] metron pull request #1271: METRON-1883 Updated org.apache.rat from 0.13-SNAP...

Posted by aurelienduarte <gi...@git.apache.org>.
Github user aurelienduarte closed the pull request at:

    https://github.com/apache/metron/pull/1271


---

[GitHub] metron issue #1271: METRON-1883 Updated org.apache.rat from 0.13-SNAPSHOT to...

Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/1271
  
    @aurelienduarte This is unfortunately a duplicate of https://github.com/apache/metron/pull/1264 (https://issues.apache.org/jira/browse/METRON-1872). Would you please close this PR?
    
    We definitely still appreciate the contribution, and I'm always glad to see people participating in the community!


---

[GitHub] metron issue #1271: Updated org.apache.rat from 0.13-SNAPSHOT to 0.13

Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1271
  
    Hi, thanks for the contribution!  Can you have a look at filling out the pr template?  This this it is especially important to look at the part about saying you have tried:
    `mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh `
    
    Thanks!


---

[GitHub] metron issue #1271: METRON-1883 Updated org.apache.rat from 0.13-SNAPSHOT to...

Posted by aurelienduarte <gi...@git.apache.org>.
Github user aurelienduarte commented on the issue:

    https://github.com/apache/metron/pull/1271
  
    always a pleasure :)


---