[jira] Updated: (SHALE-247) s:validatorScript produces invalid html markup

["Reind (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/struts/browse/SHALE-247?page=all ]

Reind updated SHALE-247:
------------------------

    Attachment: site.patch

This patch makes a small change to:

org.apache.shale.component.ValidatorScript.writeScriptStart(ResponseWriter writer)
and
org.apache.shale.component.ValidatorScript.writeScriptEnd(ResponseWriter writer)

It removes the "<!--\n" from the former and "-->\n" from the later.

This fixes the xhtml validation issues - and, hopefully, doesn't cause any other issues.

> s:validatorScript produces invalid html markup
> ----------------------------------------------
>
>                 Key: SHALE-247
>                 URL: http://issues.apache.org/struts/browse/SHALE-247
>             Project: Shale
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: Nightly
>         Environment: myfaces 1.1.5
>            Reporter: Reind
>            Priority: Minor
>         Attachments: site.patch
>
>
> The javascript that the <s:validatorScript> component generates does not validate against XHTML 1.0 Transitional using the validator on http://validator.w3.org/.
> The validation error happens because the component creates an extraneous html comment start/stop before and after the javascript it generates.
> Output:
> <script type="text/javascript" language="Javascript1.1">
> <!--
> <!--
> var bCancel = false;
> ...
> -->
> //-->
> Fix:
> <script type="text/javascript" language="Javascript1.1"><!--
> var bCancel = false;
> ...
> ...
> //-->

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira