[GitHub] [spark] viirya commented on a change in pull request #31930: [SPARK-34719][SQL] Correctly resolve the view query with duplicated column names

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #31930:
URL: https://github.com/apache/spark/pull/31930#discussion_r599331611



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1889,13 +1889,27 @@ class Analyzer(override val catalogManager: CatalogManager)
   private def resolveExpression(
       expr: Expression,
       resolveColumnByName: Seq[String] => Option[Expression],
-      resolveColumnByOrdinal: Int => Attribute,
+      resolveByOrdinalCandidates: () => Seq[Attribute],

Review comment:
       why don't just take `Seq[Attribute]`? Now we don't need ordinal param, and the candidates are static.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org