You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/14 09:41:32 UTC

[GitHub] [pulsar] fxbing commented on a change in pull request #12782: [SpotBugs][pulsar-io]Enable spotbugs for pulsar-io-hdfs2 and pulsar-io-hdfs3

fxbing commented on a change in pull request #12782:
URL: https://github.com/apache/pulsar/pull/12782#discussion_r748828338



##########
File path: pulsar-io/hdfs2/pom.xml
##########
@@ -63,6 +63,23 @@
         <groupId>org.apache.nifi</groupId>
         <artifactId>nifi-nar-maven-plugin</artifactId>
       </plugin>
+      <plugin>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <version>${spotbugs-maven-plugin.version}</version>
+        <configuration>
+            <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile>

Review comment:
       I did this because I referenced other related pr, such as #8842 and #8903.  
   Do I need to delete this file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org