You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 09:25:59 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
zhengruifeng opened a new pull request, #38654:
URL: https://github.com/apache/spark/pull/38654
### What changes were proposed in this pull request?
Document the reason of sending batch in main thread
### Why are the changes needed?
as per https://github.com/apache/spark/pull/38613#discussion_r1021041413
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
no, doc-only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38654:
URL: https://github.com/apache/spark/pull/38654#issuecomment-1313363736
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38654:
URL: https://github.com/apache/spark/pull/38654#discussion_r1021448099
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -168,8 +168,12 @@ class SparkConnectStreamHandler(responseObserver: StreamObserver[Response]) exte
resultHandler = resultHandler,
resultFunc = () => ())
- // The man thread will wait until 0-th partition is available,
+ // The main thread will wait until 0-th partition is available,
// then send it to client and wait for the next partition.
+ // Different from the implementation of [[Dataset#collectAsArrowToPython]], it send
Review Comment:
```suggestion
// Different from the implementation of [[Dataset#collectAsArrowToPython]], it sends
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38654:
URL: https://github.com/apache/spark/pull/38654#issuecomment-1314619055
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
URL: https://github.com/apache/spark/pull/38654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38654: [SPARK-41005][CONNECT][DOC][FOLLOW-UP] Document the reason of sending batch in main thread
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38654:
URL: https://github.com/apache/spark/pull/38654#issuecomment-1314634891
thank you for reivews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org