You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/07/27 01:03:45 UTC

[GitHub] [spark] Hisoka-X commented on pull request #41755: [SPARK-43999][SQL][CORE] Support force finish useless stage when AQE on

Hisoka-X commented on PR #41755:
URL: https://github.com/apache/spark/pull/41755#issuecomment-1652759143

   > The reason why I closed my pr is that we can not cancel a broadcast query stage because exchange reuse shares the broadcast future instance. It's ok to cancel a shuffle stage before executing final plan, but note that we can not cancel an intermediate shuffle stage to avoid breaking reuse shuffle exchange.
   
   Sorry about late response. I don't think the current solution will cancel the reuse stage, because this PR decides whether to cancel it by judging whether there is still a reference to a stage in the PhysicalPlan. No reference means that he will not be reused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org