You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/10/29 21:59:56 UTC
[I] fix use of deprecated code [incubator-pekko-http]
pjfanning opened a new issue, #345:
URL: https://github.com/apache/incubator-pekko-http/issues/345
```
[warn] /Users/pj.fanning/code/incubator-pekko-http/http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/HttpEntity.scala:666:23: method getFirst in class Attributes is deprecated (since Akka 2.5.7): Attributes should always be most specific, use get[T]
[warn] _attributes.getFirst[SizeLimit] match {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] fix use of deprecated code in HttpEntity [incubator-pekko-http]
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #345:
URL: https://github.com/apache/incubator-pekko-http/issues/345#issuecomment-1784706237
Yep, we tried that before and did not find an easy solution. In the best case, we would dig in and understand what the differences are and understand how to fix the problems in Pekko HTTP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] fix use of deprecated code in HttpEntity [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #345: fix use of deprecated code in HttpEntity
URL: https://github.com/apache/pekko-http/issues/345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] fix use of deprecated code in HttpEntity [pekko-http]
Posted by "c4mdax (via GitHub)" <gi...@apache.org>.
c4mdax commented on issue #345:
URL: https://github.com/apache/pekko-http/issues/345#issuecomment-5134624217
hi @pjfanning! I would like to take this up as my first contribution to Pekko
Since PR #346 showed that migrating to get breaks the test suite due to differing behavior, I'll go ahead and remove the @deprecated annotation from getFirst as you suggested
I'll open a PR shortly so you can review it. Let me know if you need anything else!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org