You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/17 22:52:17 UTC

[GitHub] [superset] gideonn opened a new pull request #17810: fix: fetch latest version of chromedriver for superset worker

gideonn opened a new pull request #17810:
URL: https://github.com/apache/superset/pull/17810


   
   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Fetch latest chromedriver to make it compatible with the latest chromebrowser
   curl flags: -S flag to show error and -s to keep it silent.
   
   ### TESTING INSTRUCTIONS
   Deploy to kubernetes with the updated config.
   The shell command can also be run on a terminal to verify that it's working and being set correctly as an env variable
   
   ### ADDITIONAL INFORMATION
   Fixes #17809 
   - [x] Has associated issue: #17809 
   - [x] Required feature flags: ALERT_REPORTS
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] gideonn commented on pull request #17810: fix: fetch latest version of chromedriver for superset worker

Posted by GitBox <gi...@apache.org>.
gideonn commented on pull request #17810:
URL: https://github.com/apache/superset/pull/17810#issuecomment-1004342020


   Any changes required here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] gideonn commented on pull request #17810: fix: fetch latest version of chromedriver for superset worker

Posted by GitBox <gi...@apache.org>.
gideonn commented on pull request #17810:
URL: https://github.com/apache/superset/pull/17810#issuecomment-997077331


   While this is a change in docs, it's also a fix. Please let me know if you want me to reword the commit/PR to reflect `docs` instead of `fix`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org