You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 21:24:04 UTC
[GitHub] [hudi] rahil-c opened a new pull request, #6229: Make AWSDmsAvroPayload class backwards compatible
rahil-c opened a new pull request, #6229:
URL: https://github.com/apache/hudi/pull/6229
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197586525
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
}, {
"hash" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409",
"triggerID" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"triggerType" : "PUSH"
}, {
"hash" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10414",
"triggerID" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c435a9e68878fd2a8239fd6f2efc281e27e82b4 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10414)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6229:
URL: https://github.com/apache/hudi/pull/6229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rahil-c commented on pull request #6229: Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
rahil-c commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197384633
cc @xushiyan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931653264
##########
hudi-common/src/test/java/org/apache/hudi/payload/TestAWSDmsAvroPayload.java:
##########
@@ -18,14 +18,13 @@
package org.apache.hudi.payload;
Review Comment:
by right the testing class package should be the same as the tested class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931625286
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/AWSDmsTransformer.java:
##########
@@ -19,8 +19,8 @@
package org.apache.hudi.utilities.transform;
import org.apache.hudi.common.config.TypedProperties;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
import org.apache.hudi.common.util.Option;
+import org.apache.hudi.payload.AWSDmsAvroPayload;
import org.apache.spark.api.java.JavaSparkContext;
Review Comment:
why this change? the old class is only meant for bwc where users are reflection-loading the class via FQCN. internal codebase should always use the new class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197548181
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
}, {
"hash" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409",
"triggerID" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"triggerType" : "PUSH"
}, {
"hash" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10414",
"triggerID" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d246c75a8724e5d3d4d046c0237d6a9c96fb8c93 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409)
* 0c435a9e68878fd2a8239fd6f2efc281e27e82b4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10414)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197427386
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197521091
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
}, {
"hash" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409",
"triggerID" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"triggerType" : "PUSH"
}, {
"hash" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10414",
"triggerID" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408)
* d246c75a8724e5d3d4d046c0237d6a9c96fb8c93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409)
* 0c435a9e68878fd2a8239fd6f2efc281e27e82b4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10414)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197430870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rahil-c commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
rahil-c commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931650280
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/payload/TestAWSDmsAvroPayload.java:
##########
@@ -18,7 +18,6 @@
package org.apache.hudi.payload;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
Review Comment:
fixed
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestAWSDatabaseMigrationServiceSource.java:
##########
@@ -18,7 +18,7 @@
package org.apache.hudi.utilities.functional;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
+import org.apache.hudi.payload.AWSDmsAvroPayload;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197479973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
}, {
"hash" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408)
* d246c75a8724e5d3d4d046c0237d6a9c96fb8c93 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197477382
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197482812
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
}, {
"hash" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409",
"triggerID" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408)
* d246c75a8724e5d3d4d046c0237d6a9c96fb8c93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rahil-c commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
rahil-c commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931681772
##########
hudi-common/src/test/java/org/apache/hudi/payload/TestAWSDmsAvroPayload.java:
##########
@@ -18,14 +18,13 @@
package org.apache.hudi.payload;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197429140
follow-up for #6211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931625350
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestAWSDatabaseMigrationServiceSource.java:
##########
@@ -18,7 +18,7 @@
package org.apache.hudi.utilities.functional;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
+import org.apache.hudi.payload.AWSDmsAvroPayload;
Review Comment:
ditto
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/AWSDmsTransformer.java:
##########
@@ -19,8 +19,8 @@
package org.apache.hudi.utilities.transform;
import org.apache.hudi.common.config.TypedProperties;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
import org.apache.hudi.common.util.Option;
+import org.apache.hudi.payload.AWSDmsAvroPayload;
import org.apache.spark.api.java.JavaSparkContext;
Review Comment:
why this change? the old class is not meant for bwc where users are loading the class via FQCN. internal codebase should always use the new class.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/payload/TestAWSDmsAvroPayload.java:
##########
@@ -18,7 +18,6 @@
package org.apache.hudi.payload;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
Review Comment:
can this test be moved to hudi-common? where the tested class belongs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6229:
URL: https://github.com/apache/hudi/pull/6229#issuecomment-1197518857
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408",
"triggerID" : "0cef10f25e931b40319bc1a9d0d0b33985533b34",
"triggerType" : "PUSH"
}, {
"hash" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409",
"triggerID" : "d246c75a8724e5d3d4d046c0237d6a9c96fb8c93",
"triggerType" : "PUSH"
}, {
"hash" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c435a9e68878fd2a8239fd6f2efc281e27e82b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cef10f25e931b40319bc1a9d0d0b33985533b34 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10408)
* d246c75a8724e5d3d4d046c0237d6a9c96fb8c93 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10409)
* 0c435a9e68878fd2a8239fd6f2efc281e27e82b4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rahil-c commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
rahil-c commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931646618
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/AWSDmsTransformer.java:
##########
@@ -19,8 +19,8 @@
package org.apache.hudi.utilities.transform;
import org.apache.hudi.common.config.TypedProperties;
-import org.apache.hudi.common.model.AWSDmsAvroPayload;
import org.apache.hudi.common.util.Option;
+import org.apache.hudi.payload.AWSDmsAvroPayload;
import org.apache.spark.api.java.JavaSparkContext;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6229: [HUDI-4490] Make AWSDmsAvroPayload class backwards compatible
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6229:
URL: https://github.com/apache/hudi/pull/6229#discussion_r931653264
##########
hudi-common/src/test/java/org/apache/hudi/payload/TestAWSDmsAvroPayload.java:
##########
@@ -18,14 +18,13 @@
package org.apache.hudi.payload;
Review Comment:
the testing class package should be the same as the tested class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org