You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/09/28 09:03:59 UTC
[GitHub] zeppelin pull request #1468: [ZEPPELIN-1502] Highlights initialization code ...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1468
[ZEPPELIN-1502] Highlights initialization code editor bugs
### What is this PR for?
When there are a variety of para graph interpreter present,
When you refresh the page, the code highlights are incorrectly applied.
### What type of PR is it?
Bug Fix
### Todos
- [x] - Create orderId key in getEditorMode function.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1502
### How should this be tested?
1. Create a para-graph form below.
```
%spark
println("spark syn 01");
```
```
%spark
println("spark syn 02");
```
```
%spark
println("spark syn 03");
```
```
%spark
println("spark syn 04");
```
```
%spark
println("spark syn 05");
```
```
%pyspark
print ("pyspark syn);
```
```
%sql
SELECT * FROM SQL_HIGH WHERE ONMYCOM
```
2. Check the highlights of each of the para graphs.
3. Refresh the page and check the highlights again.
### Screenshots (if appropriate)
#### bug (focus on pyspark)
#### this pr (focus on pyspark)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin dev/codeeditor-bugfixed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1468
----
commit eaa1b86978015e0746dfd5cdae7e08b3c86fbff5
Author: CloverHearts <cl...@gmail.com>
Date: 2016-09-28T08:32:45Z
bug fixed for page refresh initialize editor mode
commit de03a06006878f38c544d7f6ea4c4733b36b0982
Author: CloverHearts <cl...@gmail.com>
Date: 2016-09-28T08:59:43Z
remove whitespace - jslint
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1468: [ZEPPELIN-1502] Highlights initialization code editor ...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1468
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1468: [ZEPPELIN-1502] Highlights initialization code editor ...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1468
Merging if there is no more dicussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1468: [ZEPPELIN-1502] Highlights initialization code ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---