You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jason Lai <ja...@jasonlai.net> on 2018/05/17 01:25:29 UTC

Review Request 67176: Fixed target path resolution for mounts within container rootfs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67176/
-----------------------------------------------------------

Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.


Bugs: MESOS-8257
    https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
-------

The patch ensures that container mount targets that point to (or are
under) symlinks to absolute paths are resolved within the container
root filesystem, rather than to paths on host filesystem, when mounting
them prior to `chroot` (or `pivot_root`). Creation of non-existing
mount target paths is also done upon container launch, rather than by
their isolators.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp f25d90651ef32495c9161c3eaed8a327d1b2b926 


Diff: https://reviews.apache.org/r/67176/diff/1/


Testing
-------


Thanks,

Jason Lai