You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/29 01:13:19 UTC
[I] fix(cluster): ignore stale modal request results [rocketmq-dashboard]
yuluo-yx opened a new issue, #2729:
URL: https://github.com/apache/rocketmq-dashboard/issues/2729
## Problem
NameServer config-diff and cluster-connection requests update modal state without checking ownership. A result that arrives after close, reopen, or a newer request can reopen a modal or overwrite the latest result.
## Expected behavior
Only the current modal generation may publish results, loading state, or notifications; close, reopen, and unmount should invalidate older requests.
## Proposed scope
Add separate request generations for both modal flows and regressions for close and close/reopen ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix(cluster): ignore stale modal request results [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #2729: fix(cluster): ignore stale modal request results
URL: https://github.com/apache/rocketmq-dashboard/issues/2729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix(cluster): ignore stale modal request results [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2729:
URL: https://github.com/apache/rocketmq-dashboard/issues/2729#issuecomment-5459695630
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
NameServer config-diff and cluster-connection async requests update modal state without checking request ownership/generation. A delayed response from a previous request can overwrite the current modal state after close/reopen cycles.
**Root Cause:** Missing request generation tracking — async callbacks publish results without verifying they belong to the current modal generation
**Impact:** Modal UI can display stale data or reopen unexpectedly after user closes it
**Severity:** low
The proposed request generation guards with invalidation on close/reopen/unmount is the correct pattern for this class of async state management bug.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] fix(cluster): ignore stale modal request results [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #2729:
URL: https://github.com/apache/rocketmq-dashboard/issues/2729#issuecomment-5506325604
Resolved by #2851 (merged into rocketmq-studio as ca32bc80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org