[jira] Commented: (WHIRR-164) Tests fail if there is no ~/.ssh/id_rsa keypair

["Tom White (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977036#action_12977036 ] 

Tom White commented on WHIRR-164:
---------------------------------

This looks good. Just a couple of comments:

* Mark the static factory methods in ClusterSpec as @VisibleForTesting, or move them to the test where they are used.
* Can we call KeyPair.setTo600() from HadoopProxy rather than duplicating the code?

Also, the patch does not apply cleanly to trunk any more.

> Tests fail if there is no ~/.ssh/id_rsa keypair
> -----------------------------------------------
>
>                 Key: WHIRR-164
>                 URL: https://issues.apache.org/jira/browse/WHIRR-164
>             Project: Whirr
>          Issue Type: Bug
>          Components: core
>            Reporter: Tom White
>            Assignee: Andrei Savu
>            Priority: Critical
>             Fix For: 0.3.0
>
>         Attachments: WHIRR-164-after-161.patch, WHIRR-164.patch, WHIRR-164.patch
>
>
> The unit and integration tests depend on there being a ~/.ssh/id_rsa keypair.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.