You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/01/09 11:10:16 UTC

[GitHub] [hive] zchovan opened a new pull request #875: HIVE-22663: Quote all table and column names or do not quote any

zchovan opened a new pull request #875: HIVE-22663: Quote all table and column names or do not quote any
URL: https://github.com/apache/hive/pull/875
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zchovan commented on issue #875: HIVE-22663: Quote all table and column names or do not quote any

Posted by GitBox <gi...@apache.org>.
zchovan commented on issue #875: HIVE-22663: Quote all table and column names or do not quote any
URL: https://github.com/apache/hive/pull/875#issuecomment-578693688
 
 
   This change was pushed to master by @pvary 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zchovan closed pull request #875: HIVE-22663: Quote all table and column names or do not quote any

Posted by GitBox <gi...@apache.org>.
zchovan closed pull request #875: HIVE-22663: Quote all table and column names or do not quote any
URL: https://github.com/apache/hive/pull/875
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] pvary commented on a change in pull request #875: HIVE-22663: Quote all table and column names or do not quote any

Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #875: HIVE-22663: Quote all table and column names or do not quote any
URL: https://github.com/apache/hive/pull/875#discussion_r365833755
 
 

 ##########
 File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
 ##########
 @@ -368,7 +368,7 @@ public GetOpenTxnsInfoResponse getOpenTxnsInfo() throws MetaException {
          */
         dbConn = getDbConn(Connection.TRANSACTION_READ_COMMITTED);
         stmt = dbConn.createStatement();
-        String s = "select ntxn_next - 1 from NEXT_TXN_ID";
+        String s = "select \"NTXN_NEXT\" - 1 from \"NEXT_TXN_ID\"";
 
 Review comment:
   You have not capitalized this. Is this intentional?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zchovan commented on a change in pull request #875: HIVE-22663: Quote all table and column names or do not quote any

Posted by GitBox <gi...@apache.org>.
zchovan commented on a change in pull request #875: HIVE-22663: Quote all table and column names or do not quote any
URL: https://github.com/apache/hive/pull/875#discussion_r365841816
 
 

 ##########
 File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
 ##########
 @@ -368,7 +368,7 @@ public GetOpenTxnsInfoResponse getOpenTxnsInfo() throws MetaException {
          */
         dbConn = getDbConn(Connection.TRANSACTION_READ_COMMITTED);
         stmt = dbConn.createStatement();
-        String s = "select ntxn_next - 1 from NEXT_TXN_ID";
+        String s = "select \"NTXN_NEXT\" - 1 from \"NEXT_TXN_ID\"";
 
 Review comment:
   no, that one just got away :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org