You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2007/05/25 21:51:16 UTC
[jira] Created: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Redesign Tool and ToolBase API and releted functionality
--------------------------------------------------------
Key: HADOOP-1436
URL: https://issues.apache.org/jira/browse/HADOOP-1436
Project: Hadoop
Issue Type: Improvement
Components: util
Affects Versions: 0.14.0
Reporter: Enis Soztutar
Fix For: 0.14.0
With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
1. Classes do not need to extend ToolBase
2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
3. We need a ToolRunner, or similar functionality
4. Also we need each class (implementing Tool) to be runnable (main method)
5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Fix Version/s: 0.15.0
Affects Version/s: (was: 0.14.0)
0.15.0
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520685 ]
Doug Cutting commented on HADOOP-1436:
--------------------------------------
This looks reasonable to me. Does anyone have any objections, or should I commit this?
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Patch Available (was: Open)
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521686 ]
Enis Soztutar commented on HADOOP-1436:
---------------------------------------
If i were a regular hadoop user, i would prefer the issue that deprecates anything to be listed in Incompatible changes. A hadoop client, could easily ignore improvements, optimizations and bug fixes sections and go for only new features and incompatible changes.
I agree with the deprecation/removal cycle, but i do no see any counter-argument against listing both changes in incompatible changes. Notice also that HADOOP-1621 is already listed in incompatible changes section.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Patch Available (was: Open)
Resubmitting the patch, since it passes all the tests in my local PC.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Patch Available (was: Open)
retriggering build for the last patch
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518731 ]
Hadoop QA commented on HADOOP-1436:
-----------------------------------
-1, new javadoc warnings
The javadoc tool appears to have generated warning messages when testing the latest attachment http://issues.apache.org/jira/secure/attachment/12363480/redesignToolAPI_v1.1.patch against trunk revision r564012.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/537/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/537/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Open (was: Patch Available)
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520198 ]
Hadoop QA commented on HADOOP-1436:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12363918/redesignToolAPI_v1.3.patch applied and successfully tested against trunk revision r566467.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/561/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/561/console
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Attachment: redesignToolAPI_v1.2.patch
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520692 ]
Raghu Angadi commented on HADOOP-1436:
--------------------------------------
Looks good to me. I briefly went through the patch. We can commit.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Attachment: redesignToolAPI_v1.3.patch
patch updated to trunk.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518703 ]
Hadoop QA commented on HADOOP-1436:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12363480/redesignToolAPI_v1.1.patch against trunk revision r564012.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/536/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/536/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-1436:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Enis!
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Open (was: Patch Available)
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Attachment: redesignToolAndRelated_v1.0.patch
redesignToolAndRelated_v1.0.patch
This patch is intended for review. implemented basic changes discussed in HADOOP-1425. this patch :
1. deprecates ToolBase
2. introduces HadoopCommandLineParser class to parse command line options
3. ToolRunner class to run classes implementing Tool
Below are the points that i would be glad to be reviewed :
1. naming HadoopCommandLineParser (should it be CommandLineParser, or ArgumentParser, etc)
2. adding {{Tool.getOptions()}} and changing {{Tool#run(CommandLine)}}. All the actual use cases for ToolBase do not use Commons CLI.
3. -conf argument in https://issues.apache.org/jira/browse/HADOOP-1425#action_12499035
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.14.0
> Reporter: Enis Soztutar
> Fix For: 0.14.0
>
> Attachments: redesignToolAndRelated_v1.0.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519368 ]
Hadoop QA commented on HADOOP-1436:
-----------------------------------
-1, build or testing failed
2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12363572/redesignToolAPI_v1.2.patch against trunk revision r564804.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/542/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/542/console
Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Attachment: redesignToolAPI_v1.1.patch
After no apparent feedback ( *smile* ) to the previous, finally here is the complete version of the patch.
I've deprecated {{ToolBase}}, moved all functionality for parsing generic arguments to {{GenericOptionsParser}}, implemented all the functionality in {{ToolBase#doMain()}} in {{ToolRunner}}. Classes extending ToolBase can now implement Tool, and optionally extend Configured.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.14.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Attachment: redesignToolAPI_v1.2.patch
OK, here is the latest version, with javadoc warnings cleared.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Open (was: Patch Available)
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar reassigned HADOOP-1436:
-------------------------------------
Assignee: Enis Soztutar
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.14.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.14.0
>
> Attachments: redesignToolAndRelated_v1.0.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521411 ]
Enis Soztutar commented on HADOOP-1436:
---------------------------------------
Doug, i think the changes.txt log should be in the INCOMPATIBLE CHANGES section rather than IMPROVEMENTS. The patch deprecates ToolBase, which is used heavily in nutch.
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Status: Patch Available (was: Open)
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-1436:
----------------------------------
Attachment: (was: redesignToolAPI_v1.2.patch)
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1436) Redesign Tool and ToolBase API and
releted functionality
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521513 ]
Doug Cutting commented on HADOOP-1436:
--------------------------------------
> the changes.txt log should be in the INCOMPATIBLE CHANGES section rather than IMPROVEMENTS
I don't think a deprecation is an incompatibility. It doesn't break user code.
Our pattern is to try to deprecate things in one release, then remove them in a subsequent release. Then user code can run unchanged with each new release, so that the release may be easily evaluated. And, if after upgrading, you remove all uses of deprecated code, then you'll be able to upgrade to the next release. The question is, where in that cycle is the incompatible change?
Arguably, for applications that play by the rules (removing use of deprecated features in the current release before upgrading to the next release) there are no incompatible changes in this cycle. Even if we do want to label such deprecation/removal cycles as incompatible changes, we should probably choose one event or the other, deprecation or removal, as the incompatible step. I'd probably opt for removal, not deprecation. Thoughts?
> Redesign Tool and ToolBase API and releted functionality
> --------------------------------------------------------
>
> Key: HADOOP-1436
> URL: https://issues.apache.org/jira/browse/HADOOP-1436
> Project: Hadoop
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.15.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.15.0
>
> Attachments: redesignToolAndRelated_v1.0.patch, redesignToolAPI_v1.1.patch, redesignToolAPI_v1.2.patch, redesignToolAPI_v1.3.patch
>
>
> With the discussion from HADOOP-1425, we need better abstraction and better tool runner utilities.
> 1. Classes do not need to extend ToolBase
> 2. functions for parsing general HadoopCommands (-fs, -conf, -jt) should be public
> 3. We need a ToolRunner, or similar functionality
> 4. Also we need each class (implementing Tool) to be runnable (main method)
> 5. CLI objects can be passed to run method of the Tool class (arguable)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.