You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/24 02:03:22 UTC
[GitHub] [spark] pan3793 opened a new pull request, #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
pan3793 opened a new pull request, #42639:
URL: https://github.com/apache/spark/pull/42639
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Change default value of `spark.sql.maxSinglePartitionBytes` from `Long.maxValue` to `128m`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
`spark.sql.maxSinglePartitionBytes` was introduced in SPARK-41986(https://github.com/apache/spark/pull/39512), and the default value was set to `Long.maxValue` for the safety.
Recently, we hit the same issue described in the SPARK-41986, and setting it to `128m` works fine in our internal cluster.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the migration guide was updated correspondingly.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
URL: https://github.com/apache/spark/pull/42639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303995020
##########
docs/sql-migration-guide.md:
##########
@@ -30,6 +30,7 @@ license: |
- Since Spark 3.5, the `plan` field is moved from `AnalysisException` to `EnhancedAnalysisException`.
- Since Spark 3.5, `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` is enabled by default. To restore the previous behavior, set `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` to `false`.
- Since Spark 3.5, the `array_insert` function is 1-based for negative indexes. It inserts new element at the end of input arrays for the index -1. To restore the previous behavior, set `spark.sql.legacy.negativeIndexInArrayInsert` to `true`.
+- Since Spark 3.5, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
Moved to `3.5 to 4.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304023439
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
Ah, got it. I was confused. BTW, the test name is `test("A cached table preserves the partitioning and ordering of its cached SparkPlan"`. So, after this PR, Spark doesn't preserve the partitioning and ordering of its cached SparkPlan for cached tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304027245
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
No, still valid. With `MAX_SINGLE_PARTITION_BYTES=128m`, the assertion in `verifyNumExchanges` may fail because it may insert new Exchange nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303938039
##########
docs/sql-migration-guide.md:
##########
@@ -30,6 +30,7 @@ license: |
- Since Spark 3.5, the `plan` field is moved from `AnalysisException` to `EnhancedAnalysisException`.
- Since Spark 3.5, `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` is enabled by default. To restore the previous behavior, set `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` to `false`.
- Since Spark 3.5, the `array_insert` function is 1-based for negative indexes. It inserts new element at the end of input arrays for the index -1. To restore the previous behavior, set `spark.sql.legacy.negativeIndexInArrayInsert` to `true`.
+- Since Spark 3.5, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
It's too late for Apache Spark 3.5.0 because we are on RC2 already. Please target this 4.0, @pan3793 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #42639:
URL: https://github.com/apache/spark/pull/42639#issuecomment-1690879402
cc @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303993069
##########
docs/sql-migration-guide.md:
##########
@@ -30,6 +30,7 @@ license: |
- Since Spark 3.5, the `plan` field is moved from `AnalysisException` to `EnhancedAnalysisException`.
- Since Spark 3.5, `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` is enabled by default. To restore the previous behavior, set `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` to `false`.
- Since Spark 3.5, the `array_insert` function is 1-based for negative indexes. It inserts new element at the end of input arrays for the index -1. To restore the previous behavior, set `spark.sql.legacy.negativeIndexInArrayInsert` to `true`.
+- Since Spark 3.5, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
The sentence clearly says we change the default value of conf `xyz` from `A` to `B`, seems too redundant with `To restore the previous behavior, set xyz=A`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303989432
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
`MAX_SINGLE_PARTITION_BYTES=128m` causes the plan change seems reasonable to me, WDYT ?@wangyum
And the only change here is
```patch
+ withSQLConf(SQLConf.MAX_SINGLE_PARTITION_BYTES.key -> Long.MaxValue.toString) {
// original code with additional two leading spaces
+ }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304026777
##########
docs/sql-migration-guide.md:
##########
@@ -22,6 +22,10 @@ license: |
* Table of contents
{:toc}
+## Upgrading from Spark SQL 3.5 to 4.0
+
+- Since Spark 4.0, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
Thank you for moving to 4.0. Although it's obvious, we still need a directional guide to restore. Please see my previous comment, https://github.com/apache/spark/pull/42639#discussion_r1303993069.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42639:
URL: https://github.com/apache/spark/pull/42639#issuecomment-1692071451
Merged to master for Apache Spark 4. Thank you, @pan3793 , @wangyum , and @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #42639:
URL: https://github.com/apache/spark/pull/42639#issuecomment-1690891943
Looks okay to me. cc @cloud-fan @sunchao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303989432
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
`MAX_SINGLE_PARTITION_BYTES=128m` causes the plan change seems reasonable to me, WDYT ?@wangyum
And the only change here is
```patch
+ withSQLConf(SQLConf.MAX_SINGLE_PARTITION_BYTES.key -> Long.MaxValue.toString) {
// original code with additional two leading spaces and necessary style adjust to meet scalastyle requirement
+ }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304038888
##########
docs/sql-migration-guide.md:
##########
@@ -22,6 +22,10 @@ license: |
* Table of contents
{:toc}
+## Upgrading from Spark SQL 3.5 to 4.0
+
+- Since Spark 4.0, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
@dongjoon-hyun how about now? Since the string literal `Long.MaxValue` does not work.
```
... to `9223372036854775807`(`Long.MaxValue`).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304023439
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
Ah, got it. I was confused. BTW, the test name is `test("A cached table preserves the partitioning and ordering of its cached SparkPlan"`. So, after this PR, Spark doesn't preserve the partitioning and ordering of its cached SparkPlan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304028258
##########
docs/sql-migration-guide.md:
##########
@@ -22,6 +22,10 @@ license: |
* Table of contents
{:toc}
+## Upgrading from Spark SQL 3.5 to 4.0
+
+- Since Spark 4.0, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
What I'm asking is adding the following, @pan3793 .
```
To restore the previous behavior, set `spark.sql.maxSinglePartitionBytes` to `Long.MaxValue`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303945138
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
If we need to change this, this looks like a side-effect of this change. What is the changed `assert` statement in the test code, @pan3793 ? For me, `numPartitions` seems to be still 6 and 12 in the same line (before and after).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303939700
##########
docs/sql-migration-guide.md:
##########
@@ -30,6 +30,7 @@ license: |
- Since Spark 3.5, the `plan` field is moved from `AnalysisException` to `EnhancedAnalysisException`.
- Since Spark 3.5, `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` is enabled by default. To restore the previous behavior, set `spark.sql.optimizer.canChangeCachedPlanOutputPartitioning` to `false`.
- Since Spark 3.5, the `array_insert` function is 1-based for negative indexes. It inserts new element at the end of input arrays for the index -1. To restore the previous behavior, set `spark.sql.legacy.negativeIndexInArrayInsert` to `true`.
+- Since Spark 3.5, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
Please add a sentence, `To restore the previous behavior ...`, additionally to be clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1304038888
##########
docs/sql-migration-guide.md:
##########
@@ -22,6 +22,10 @@ license: |
* Table of contents
{:toc}
+## Upgrading from Spark SQL 3.5 to 4.0
+
+- Since Spark 4.0, the default value of `spark.sql.maxSinglePartitionBytes` is changed from `Long.MaxValue` to `128m`.
Review Comment:
@dongjoon-hyun how about now? Since the string literal `Long.MaxValue` does not work.
```
... to `9223372036854775807`(the value of `Long.MaxValue`).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #42639:
URL: https://github.com/apache/spark/pull/42639#discussion_r1303989432
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
`MAX_SINGLE_PARTITION_BYTES=128m` causes the plan change seems reasonable to me, WDYT ?@wangyum
And the only change here is
```patch
+ withSQLConf(SQLConf.MAX_SINGLE_PARTITION_BYTES.key -> Long.MaxValue.toString) {
// original code with additional two leading spaces and necessary style adjust to satisfy scalastyle requirement
+ }
```
##########
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala:
##########
@@ -522,146 +522,152 @@ class CachedTableSuite extends QueryTest with SQLTestUtils
}
test("A cached table preserves the partitioning and ordering of its cached SparkPlan") {
- val table3x = testData.union(testData).union(testData)
- table3x.createOrReplaceTempView("testData3x")
-
- sql("SELECT key, value FROM testData3x ORDER BY key").createOrReplaceTempView("orderedTable")
- spark.catalog.cacheTable("orderedTable")
- assertCached(spark.table("orderedTable"))
- // Should not have an exchange as the query is already sorted on the group by key.
- verifyNumExchanges(sql("SELECT key, count(*) FROM orderedTable GROUP BY key"), 0)
- checkAnswer(
- sql("SELECT key, count(*) FROM orderedTable GROUP BY key ORDER BY key"),
- sql("SELECT key, count(*) FROM testData3x GROUP BY key ORDER BY key").collect())
- uncacheTable("orderedTable")
- spark.catalog.dropTempView("orderedTable")
-
- // Set up two tables distributed in the same way. Try this with the data distributed into
- // different number of partitions.
- for (numPartitions <- 1 until 10 by 4) {
+ // Set MAX_SINGLE_PARTITION_BYTES to Long.MaxValue to avoid inserting Exchange node
Review Comment:
`MAX_SINGLE_PARTITION_BYTES=128m` causes the plan change seems reasonable to me, WDYT? @wangyum
And the only change here is
```patch
+ withSQLConf(SQLConf.MAX_SINGLE_PARTITION_BYTES.key -> Long.MaxValue.toString) {
// original code with additional two leading spaces and necessary style adjust to satisfy scalastyle requirement
+ }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #42639: [SPARK-44938][SQL] Change default value of `spark.sql.maxSinglePartitionBytes` to 128m
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #42639:
URL: https://github.com/apache/spark/pull/42639#issuecomment-1692633986
Thanks all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org