You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:20:16 UTC
[GitHub] [flink] zentol opened a new pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
zentol opened a new pull request #12344:
URL: https://github.com/apache/flink/pull/12344
With this PR we only print 500 from each log file if an error/exception etc was found.
This is to prevent issues with ungodly long log files caused by some tests. This is usually only an error on Travis (so it only really applies to 1.10/1.9), but I think there could be value in restricting this at all times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12344:
URL: https://github.com/apache/flink/pull/12344#issuecomment-642787816
This breaks the scripts on macOS, `--lines` doesn't work, but `-n` does. I pushed fixes to `master` and `release-1.11`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12344:
URL: https://github.com/apache/flink/pull/12344#issuecomment-634010415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #12344:
URL: https://github.com/apache/flink/pull/12344#discussion_r431071033
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -366,7 +366,7 @@ function check_logs_for_errors {
| grep -ic "error" || true)
if [[ ${error_count} -gt 0 ]]; then
echo "Found error in log files:"
Review comment:
Can we add here that only a part of the log files are printed and that one should access the log files for a proper analysis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #12344:
URL: https://github.com/apache/flink/pull/12344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12344:
URL: https://github.com/apache/flink/pull/12344#issuecomment-634118627
that should already be done afaik: https://github.com/apache/flink/blob/master/flink-end-to-end-tests/test-scripts/test-runner-common.sh#L99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12344:
URL: https://github.com/apache/flink/pull/12344#issuecomment-634024531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12344:
URL: https://github.com/apache/flink/pull/12344#discussion_r431146976
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -366,7 +366,7 @@ function check_logs_for_errors {
| grep -ic "error" || true)
if [[ ${error_count} -gt 0 ]]; then
echo "Found error in log files:"
Review comment:
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12344: [FLINK-16694][ci] Limit number of dumped log lines
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12344:
URL: https://github.com/apache/flink/pull/12344#issuecomment-634021233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org