You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2006/01/25 18:48:58 UTC
Re: svn commit: r18228 - trunk/subversion/tests/libsvn_fs_base
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
sussman@tigris.org wrote:
> Author: sussman
> Date: Wed Jan 25 13:01:24 2006
> New Revision: 18228
>
> Modified:
> trunk/subversion/tests/libsvn_fs_base/fs-base-test.c
>
> Log:
> Improve an fs-base-test.
>
> * subversion/tests/libsvn_fs_base/fs-base-test.c
> (create_within_copy): instead of testing for specific id triplets,
> just test that children properly inherit copy-id's from parents.
Can this test be moved into libsvn_fs/fs-test.c then (and tweaked to not
hard-code a "bdb" backend type)? Is it backend-inspecific as of your
change?
- --
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFD18gaokEGqRcG/W4RAg2+AJwN2BuAMv5s91S0S/mutj+0wXaIAACghVjf
BjTZLZlTXfe7cL3xt7F6vr8=
=iuv0
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r18228 - trunk/subversion/tests/libsvn_fs_base
Posted by "C. Michael Pilato" <cm...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ben Collins-Sussman wrote:
> On 1/25/06, C. Michael Pilato <cm...@collab.net> wrote:
>
>
>>Can this test be moved into libsvn_fs/fs-test.c then (and tweaked to not
>>hard-code a "bdb" backend type)? Is it backend-inspecific as of your
>>change?
>
>
> Hm, in general, it *shouldn't* be a backend-specific test, but it
> still is, just barely. The only thing that's bdb-specific is the two
> calls to svn_fs_base__id_copy_id(). AFAIK, we don't actually have
> public fs functions to return components of node-id triplets, do we?
>
Nope -- those are implementation details of the FS layer.
- --
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFD182SokEGqRcG/W4RAht6AKCqmoUZUhlcmyhvjZwNXYMPwa3lJACcDhdY
QlaG559NixhhXRIKq1z80Pc=
=ZtDT
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r18228 - trunk/subversion/tests/libsvn_fs_base
Posted by Ben Collins-Sussman <su...@red-bean.com>.
On 1/25/06, C. Michael Pilato <cm...@collab.net> wrote:
> Can this test be moved into libsvn_fs/fs-test.c then (and tweaked to not
> hard-code a "bdb" backend type)? Is it backend-inspecific as of your
> change?
Hm, in general, it *shouldn't* be a backend-specific test, but it
still is, just barely. The only thing that's bdb-specific is the two
calls to svn_fs_base__id_copy_id(). AFAIK, we don't actually have
public fs functions to return components of node-id triplets, do we?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org