[GitHub] [ratis] szetszwo commented on a change in pull request #617: RATIS-1547. Make GrpcClientProtocolService and log to public

[GitBox <gi...@apache.org>]

szetszwo commented on a change in pull request #617:
URL: https://github.com/apache/ratis/pull/617#discussion_r818697351



##########
File path: ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcClientProtocolService.java
##########
@@ -48,8 +48,8 @@
 import java.util.function.Consumer;
 import java.util.function.Supplier;
 
-class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase {
-  private static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class);
+public class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase {
+  public static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class);

Review comment:
       @captainzmc , sorry that GrpcClientProtocolService is not a public API.  We should not change it for an Ozone unit test.  We should fix the test instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org