You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/12/18 00:57:57 UTC
[Apache Bloodhound] #313: Diff CSS includes margin at the top of
sticky panel
#313: Diff CSS includes margin at the top of sticky panel
-------------------+------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: major | Component: ui design
Version: | Resolution:
-------------------+------------------------
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Changes (by olemis):
* priority: major => trivial
* cc: olemis+bh@… (added)
* keywords: => diff css bootstrap affix starter
* milestone: => Release 4
Old description:
New description:
Default `diff.css` adds margin at the top of sticky panel , and thereby
page contents are visible as they scroll underneath . Detected while
watching #234 .
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by olemis):
Replying to [comment:7 gjm]:
> As a quick way to revert the problems from keeping {{{diff.css}}} I
suppose we could do this:
>
> {{{
> #!css
> #overview.stickyStatus {
> line-height: 20px;
> margin-top: 0;
> padding: 0;
> }
> }}}
fwiw +1
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by rjollos):
I can see the issue present in #234, but not in #312. Any idea of why that
is?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by jdreimann):
I noticed this before but never new what caused it. Good find there
olemis!
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by rjollos):
Replying to [comment:5 rjollos]:
> Thanks, that makes sense, and is well explained in the ticket. I hadn't
read this carefully enough.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by olemis):
Replying to [comment:3 rjollos]:
> I can see the issue present in #234, but not in #312. Any idea of why
that is?
Because diff.css is not included in #312 ? I mean there's no inline
diff/patch rendered in #321 .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by gjm):
As a quick way to revert the problems from keeping {{{diff.css}}} I
suppose we could do this:
{{{
#!css
#overview.stickyStatus {
line-height: 20px;
margin-top: 0;
padding: 0;
}
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #313: Diff CSS includes margin at the top
of sticky panel
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#313: Diff CSS includes margin at the top of sticky panel
------------------------+----------------------------------------------
Reporter: olemis | Owner: nobody
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: diff css bootstrap affix starter
------------------------+----------------------------------------------
Comment (by rjollos):
Thanks that makes sense, and is well explained in the ticket. I hadn't
read this carefully enough.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/313#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker