You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2019/09/10 20:02:46 UTC
[Impala-ASF-CR] IMPALA-8897 (part 3): Fix some additional javascript urls
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14206
Change subject: IMPALA-8897 (part 3): Fix some additional javascript urls
......................................................................
IMPALA-8897 (part 3): Fix some additional javascript urls
Part 2 of this patch missed rewriting two urls in javascript.
This patch fixes it by adding 'make_url()' around those urls.
Testing:
- Deployed to a real cluster and verified that Knox integreation
works correctly on the relevant pages now.
- Extended test_knox_integration to check for this case.
Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
---
M tests/webserver/test_web_pages.py
M www/query_backends.tmpl
M www/query_finstances.tmpl
3 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/14206/1
--
To view, visit http://gerrit.cloudera.org:8080/14206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Gerrit-Change-Number: 14206
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8897 (part 3): Fix some additional javascript urls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14206 )
Change subject: IMPALA-8897 (part 3): Fix some additional javascript urls
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4929/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Gerrit-Change-Number: 14206
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 20:03:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8897 (part 3): Fix some additional javascript urls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14206 )
Change subject: IMPALA-8897 (part 3): Fix some additional javascript urls
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Gerrit-Change-Number: 14206
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Sep 2019 00:09:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8897 (part 3): Fix some additional javascript urls
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14206 )
Change subject: IMPALA-8897 (part 3): Fix some additional javascript urls
......................................................................
IMPALA-8897 (part 3): Fix some additional javascript urls
Part 2 of this patch missed rewriting two urls in javascript.
This patch fixes it by adding 'make_url()' around those urls.
Testing:
- Deployed to a real cluster and verified that Knox integreation
works correctly on the relevant pages now.
- Extended test_knox_integration to check for this case.
Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Reviewed-on: http://gerrit.cloudera.org:8080/14206
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
M www/query_backends.tmpl
M www/query_finstances.tmpl
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Gerrit-Change-Number: 14206
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8897 (part 3): Fix some additional javascript urls
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14206 )
Change subject: IMPALA-8897 (part 3): Fix some additional javascript urls
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4523/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Gerrit-Change-Number: 14206
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 20:44:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8897 (part 3): Fix some additional javascript urls
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14206 )
Change subject: IMPALA-8897 (part 3): Fix some additional javascript urls
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a099b3a23324ad56133c5584d6a9bc88541582
Gerrit-Change-Number: 14206
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 21:52:51 +0000
Gerrit-HasComments: No