[GitHub] [hadoop] bshashikant commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type.
URL: https://github.com/apache/hadoop/pull/1313#discussion_r316505447
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshotDiffReport.java
 ##########
 @@ -75,36 +75,55 @@ public static DiffType parseDiffType(String s){
     }
   }
 
+  /**
+   * INodeType specifies the type of INode: FILE, DIRECTORY, or SYMLINK.
+   */
+  public enum INodeType {
+    FILE,
+    DIRECTORY,
+    SYMLINK;
+
+    public static INodeType parseINodeType(String s) {
+      return INodeType.valueOf(s.toUpperCase());
+    }
+  }
+
   /**
    * Representing the full path and diff type of a file/directory where changes
    * have happened.
    */
   public static class DiffReportEntry {
     /** The type of the difference. */
     private final DiffType type;
 
 Review comment:
   Let's be consistent with the naming of the variable  "iNodeType" to inodeType.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org