You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by wa...@apache.org on 2023/01/18 14:17:37 UTC
[incubator-devlake] branch main updated: fix(framework): assign labels to dbpipeline in CreateDbPipeline (#4232)
This is an automated email from the ASF dual-hosted git repository.
warren pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 1e2b351f4 fix(framework): assign labels to dbpipeline in CreateDbPipeline (#4232)
1e2b351f4 is described below
commit 1e2b351f4cd2ba86e913c3f11159f409e62718cc
Author: Warren Chen <yi...@merico.dev>
AuthorDate: Wed Jan 18 22:17:32 2023 +0800
fix(framework): assign labels to dbpipeline in CreateDbPipeline (#4232)
---
backend/server/services/pipeline.go | 4 ----
backend/server/services/pipeline_helper.go | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/backend/server/services/pipeline.go b/backend/server/services/pipeline.go
index cd52e9daa..07be063eb 100644
--- a/backend/server/services/pipeline.go
+++ b/backend/server/services/pipeline.go
@@ -114,10 +114,6 @@ func CreatePipeline(newPipeline *models.NewPipeline) (*models.Pipeline, errors.E
if err != nil {
return nil, errors.Convert(err)
}
- err = fillPipelineDetail(pipeline)
- if err != nil {
- return nil, errors.Convert(err)
- }
return pipeline, nil
}
diff --git a/backend/server/services/pipeline_helper.go b/backend/server/services/pipeline_helper.go
index 5884bf532..03f3e322b 100644
--- a/backend/server/services/pipeline_helper.go
+++ b/backend/server/services/pipeline_helper.go
@@ -115,7 +115,7 @@ func CreateDbPipeline(newPipeline *models.NewPipeline) (*models.Pipeline, errors
globalPipelineLog.Error(err, "update pipline state failed: %v", err)
return nil, errors.Internal.Wrap(err, "update pipline state failed")
}
-
+ dbPipeline.Labels = newPipeline.Labels
return dbPipeline, nil
}