You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2008/04/16 10:22:22 UTC
[jira] Created: (WICKET-1541) PopupSettings' windowName fixes for
IE
PopupSettings' windowName fixes for IE
--------------------------------------
Key: WICKET-1541
URL: https://issues.apache.org/jira/browse/WICKET-1541
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.2
Environment: Internet Explorer 6/7
Reporter: Martin Grigorov
Priority: Trivial
In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
// Fix for IE bug.
windowTitle = windowTitle.replace(':', '_');
This fix should either be improved/extended or there would be stated in the javadocs for 'pageMap' that IE supports only alphanumeric characters
and underscore in the windowTitle.
Attached quickstart shows the problem in IE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1541) PopupSettings' windowName fixes for
IE
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz updated WICKET-1541:
---------------------------------
Fix Version/s: 1.4-M2
1.3.4
Assignee: Gerolf Seitz
Issue Type: Bug (was: Improvement)
Affects Version/s: (was: 1.3.2)
1.3.3
1.4-M1
> PopupSettings' windowName fixes for IE
> --------------------------------------
>
> Key: WICKET-1541
> URL: https://issues.apache.org/jira/browse/WICKET-1541
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3, 1.4-M1
> Environment: Internet Explorer 6/7
> Reporter: Martin Grigorov
> Assignee: Gerolf Seitz
> Priority: Trivial
> Fix For: 1.3.4, 1.4-M2
>
> Attachments: popups.tgz
>
>
> In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
> // Fix for IE bug.
> windowTitle = windowTitle.replace(':', '_');
> This fix should either be improved/extended or it would be good if the javadocs for 'pageMap' state that IE supports only alphanumeric characters
> and underscore in the windowTitle.
> Attached quickstart shows the problem in IE: a pageMap/windowTitle with a dash leads to "Illegal argument" JavaScript error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1541) PopupSettings' windowName fixes for
IE
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz resolved WICKET-1541.
----------------------------------
Resolution: Fixed
from now on, all non-word characters [^0-9A-Za-z_] in the window title will be replaced with the underscore character '_'
> PopupSettings' windowName fixes for IE
> --------------------------------------
>
> Key: WICKET-1541
> URL: https://issues.apache.org/jira/browse/WICKET-1541
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3, 1.4-M1
> Environment: Internet Explorer 6/7
> Reporter: Martin Grigorov
> Assignee: Gerolf Seitz
> Priority: Trivial
> Fix For: 1.3.4, 1.4-M2
>
> Attachments: popups.tgz
>
>
> In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
> // Fix for IE bug.
> windowTitle = windowTitle.replace(':', '_');
> This fix should either be improved/extended or it would be good if the javadocs for 'pageMap' state that IE supports only alphanumeric characters
> and underscore in the windowTitle.
> Attached quickstart shows the problem in IE: a pageMap/windowTitle with a dash leads to "Illegal argument" JavaScript error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1541) PopupSettings' windowName fixes for
IE
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-1541:
------------------------------------
Attachment: popups.tgz
> PopupSettings' windowName fixes for IE
> --------------------------------------
>
> Key: WICKET-1541
> URL: https://issues.apache.org/jira/browse/WICKET-1541
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Environment: Internet Explorer 6/7
> Reporter: Martin Grigorov
> Priority: Trivial
> Attachments: popups.tgz
>
>
> In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
> // Fix for IE bug.
> windowTitle = windowTitle.replace(':', '_');
> This fix should either be improved/extended or there would be stated in the javadocs for 'pageMap' that IE supports only alphanumeric characters
> and underscore in the windowTitle.
> Attached quickstart shows the problem in IE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1541) PopupSettings' windowName fixes for
IE
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-1541:
------------------------------------
Description:
In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
// Fix for IE bug.
windowTitle = windowTitle.replace(':', '_');
This fix should either be improved/extended or it would be good if the javadocs for 'pageMap' state that IE supports only alphanumeric characters
and underscore in the windowTitle.
Attached quickstart shows the problem in IE: a pageMap/windowTitle with a dash leads to "Illegal argument" JavaScript error.
was:
In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
// Fix for IE bug.
windowTitle = windowTitle.replace(':', '_');
This fix should either be improved/extended or there would be stated in the javadocs for 'pageMap' that IE supports only alphanumeric characters
and underscore in the windowTitle.
Attached quickstart shows the problem in IE.
> PopupSettings' windowName fixes for IE
> --------------------------------------
>
> Key: WICKET-1541
> URL: https://issues.apache.org/jira/browse/WICKET-1541
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.2
> Environment: Internet Explorer 6/7
> Reporter: Martin Grigorov
> Priority: Trivial
> Attachments: popups.tgz
>
>
> In o.a.w.markup.html.link.PopupSettings.java there is a fix for IE at line 177:
> // Fix for IE bug.
> windowTitle = windowTitle.replace(':', '_');
> This fix should either be improved/extended or it would be good if the javadocs for 'pageMap' state that IE supports only alphanumeric characters
> and underscore in the windowTitle.
> Attached quickstart shows the problem in IE: a pageMap/windowTitle with a dash leads to "Illegal argument" JavaScript error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.