[GitHub] [helix] xyuanlu commented on a change in pull request #1913: Implement RestSnapShot and substitute the kv maps in HelixDataAccessorWrapper to a RestSnapShot object

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1913:
URL: https://github.com/apache/helix/pull/1913#discussion_r760529385



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/common/HelixDataAccessorWrapper.java
##########
@@ -91,6 +93,35 @@ public HelixDataAccessorWrapper(ZKHelixDataAccessor dataAccessor,
     super(dataAccessor);
     _restClient = customRestClient;
     _namespace = namespace;
+    _restSnapShot = new RestSnapshotWrapper(_clusterName);
+  }
+
+  static class RestSnapshotWrapper extends RestSnapShot {

Review comment:
       TFTR. We need to access the generic getter and setter in DataAccessorWrapper, but the getter and setter is private in the RestSnapShot class. So I extends RestSnapShot tp have access to these private functions. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org