You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/13 11:04:01 UTC
[GitHub] [ignite-3] valepakh opened a new pull request, #1442: IGNITE-18280 Declare proper dependencies in the packaging tasks
valepakh opened a new pull request, #1442:
URL: https://github.com/apache/ignite-3/pull/1442
https://issues.apache.org/jira/browse/IGNITE-18280
This fix properly declares dependencies between packaging tasks so that the gradle can optimize them correctly and don't complain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] valepakh commented on a diff in pull request #1442: IGNITE-18280 Fix dependencies in Gradle packaging tasks
Posted by GitBox <gi...@apache.org>.
valepakh commented on code in PR #1442:
URL: https://github.com/apache/ignite-3/pull/1442#discussion_r1052981658
##########
packaging/build.gradle:
##########
@@ -142,6 +141,7 @@ task prepareRelease(type: Copy) {
from configurations.platformsRelease
dependsOn createChecksums, signAllSrcZip, signAllDistZip
from file("$buildDir/distributions")
+ from file("$buildDir/checksums")
Review Comment:
We take the files from distributions and checksums folders directly since they are not declare outputs correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Pochatkin commented on pull request #1442: IGNITE-18280 Declare proper dependencies in the packaging tasks
Posted by GitBox <gi...@apache.org>.
Pochatkin commented on PR #1442:
URL: https://github.com/apache/ignite-3/pull/1442#issuecomment-1358917936
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn merged pull request #1442: IGNITE-18280 Fix dependencies in Gradle packaging tasks
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged PR #1442:
URL: https://github.com/apache/ignite-3/pull/1442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1442: IGNITE-18280 Declare proper dependencies in the packaging tasks
Posted by GitBox <gi...@apache.org>.
PakhomovAlexander commented on code in PR #1442:
URL: https://github.com/apache/ignite-3/pull/1442#discussion_r1047071251
##########
packaging/build.gradle:
##########
@@ -142,6 +141,7 @@ task prepareRelease(type: Copy) {
from configurations.platformsRelease
dependsOn createChecksums, signAllSrcZip, signAllDistZip
from file("$buildDir/distributions")
+ from file("$buildDir/checksums")
Review Comment:
shouldn't it be `platformsRelease` artifact instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org