You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/18 07:55:08 UTC
[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18970: [fix] [tx] [branch-2.9] Transaction buffer recover blocked by readNext
congbobo184 commented on code in PR #18970:
URL: https://github.com/apache/pulsar/pull/18970#discussion_r1051548518
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -632,6 +641,14 @@ public void run() {
callBack.noNeedToRecover();
return;
}
+ } catch (TimeoutException ex) {
+ Throwable t = FutureUtil.unwrapCompletionException(ex);
+ String errorMessage = String.format("[%s] Transaction buffer recover fail by read "
+ + "transactionBufferSnapshot timeout!", topic.getName());
+ log.error(errorMessage, t);
+ callBack.recoverExceptionally(
+ new BrokerServiceException.ServiceUnitNotReadyException(errorMessage, t));
Review Comment:
should close the reader right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org