[GitHub] [flink] KarmaGYZ commented on a diff in pull request #23403: [FLINK-32863][runtime-web] Improve Flink UI's time precision from sec…

["KarmaGYZ (via GitHub)" <gi...@apache.org>]

KarmaGYZ commented on code in PR #23403:
URL: https://github.com/apache/flink/pull/23403#discussion_r1324171749


##########
flink-runtime-web/web-dashboard/src/app/components/humanize-duration.pipe.ts:
##########
@@ -46,23 +46,23 @@ export class HumanizeDurationPipe implements PipeTransform {
             if (seconds === 0) {
               return `${ms}ms`;
             } else {
-              return `${seconds}s`;
+              return `${seconds}s ${ms}ms`;
             }
           } else {
-            return `${minutes}m ${seconds}s`;
+            return `${minutes}m ${seconds}s ${ms}ms`;
           }
         } else {
           if (short) {
             return `${hours}h ${minutes}m`;
           } else {
-            return `${hours}h ${minutes}m ${seconds}s`;
+            return `${hours}h ${minutes}m ${seconds}s ${ms}ms`;
           }
         }
       } else {
         if (short) {
           return `${days}d ${hours}h`;
         } else {
-          return `${days}d ${hours}h ${minutes}m ${seconds}s`;
+          return `${days}d ${hours}h ${minutes}m ${seconds}s ${ms}ms`;

Review Comment:
   nit: I think the explicit ms might be useless for jobs longer than 1h.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org