[jira] [Commented] (YARN-3157) Improvement for ConverterUtils

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310843#comment-14310843 ] 

Hadoop QA commented on YARN-3157:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12697271/YARN-3157.patch
  against trunk revision cfb829e.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6549//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6549//console

This message is automatically generated.

> Improvement for ConverterUtils 
> -------------------------------
>
>                 Key: YARN-3157
>                 URL: https://issues.apache.org/jira/browse/YARN-3157
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: YARN-3157.patch
>
>
> yarn.cmd application -kill application_123
> Format wrong given for application id or attempt. Exception will be thrown to console with out any info
> {quote}
> 15/02/07 22:18:01 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where
> Exception in thread "main" java.util.NoSuchElementException
>         at com.google.common.base.AbstractIterator.next(AbstractIterator.java:75)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:146)
>         at org.apache.hadoop.yarn.util.ConverterUtils.toApplicationId(ConverterUtils.java:205)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.killApplication(ApplicationCLI.java:383)
>         at org.apache.hadoop.yarn.client.cli.ApplicationCLI.run(ApplicationCLI.java:219)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> {quote}
> Need to add catch block for java.util.NoSuchElementException also



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)