You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/09 03:26:58 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use 3.2.13
LuciferYang opened a new pull request, #37842:
URL: https://github.com/apache/spark/pull/37842
### What changes were proposed in this pull request?
Will update later
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
URL: https://github.com/apache/spark/pull/37842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #37842:
URL: https://github.com/apache/spark/pull/37842#issuecomment-1245019933
branch-3.3 uses the abandoned version `3.3.0-SNAP3` now, I suggest we backport this PR to branch-3.3 cc @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37842:
URL: https://github.com/apache/spark/pull/37842#issuecomment-1242936168
+1, LGTM. Merging to master.
Thank you, @LuciferYang and @srowen for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967243275
##########
pom.xml:
##########
@@ -1139,37 +1139,38 @@
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
- <version>3.3.0-SNAP3</version>
+ <version>3.2.13</version>
Review Comment:
Not downgrade:
1. https://search.maven.org/artifact/org.scalatest/scalatest_2.12
<img width="977" alt="image" src="https://user-images.githubusercontent.com/1475305/189393708-d31defe2-08ea-41e5-956f-21548cc72773.png">
The update time of `3.3.0-SNAP3` is 11-Dec-2020, this is earlier than the release of 3.2.4
2. https://github.com/scalatest/scalatest/tags
There is no 3.3.x officially tag and it seems that the 3.3.x branch is still under development or has been abandoned(The latest commit was 16 Mar)
So I don't think we should use this version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967248466
##########
pom.xml:
##########
@@ -1139,37 +1139,38 @@
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
- <version>3.3.0-SNAP3</version>
+ <version>3.2.13</version>
Review Comment:
Later in time doesn't mean later version. If you're just saying this seems like a somewhat abandoned 3.3.x release, OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967068327
##########
pom.xml:
##########
@@ -1139,37 +1139,38 @@
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
- <version>3.3.0-SNAP3</version>
+ <version>3.2.13</version>
Review Comment:
This seems like a downgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37842:
URL: https://github.com/apache/spark/pull/37842#issuecomment-1242940162
thanks @srowen and @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37842:
URL: https://github.com/apache/spark/pull/37842#issuecomment-1245023041
> branch-3.3 uses the abandoned version `3.3.0-SNAP3` now, I suggest we backport this PR to branch-3.3 cc @wangyum
This pr also upgrade scala-xml from 1.20 to 2.1.0, maybe we need try to find a version that doesn't need to upgrade `scala-xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #37842: [SPARK-40396][BUILD] Update scalatest and scalatestplus related dependencies to use stable version
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #37842:
URL: https://github.com/apache/spark/pull/37842#discussion_r967250684
##########
pom.xml:
##########
@@ -1109,7 +1109,7 @@
<dependency>
<groupId>org.scala-lang.modules</groupId>
<artifactId>scala-xml_${scala.binary.version}</artifactId>
- <version>1.2.0</version>
+ <version>2.1.0</version>
Review Comment:
update this due to
<img width="746" alt="image" src="https://user-images.githubusercontent.com/1475305/189395697-379c070a-737c-40af-ae7c-049623d86b67.png">
##########
pom.xml:
##########
@@ -1109,7 +1109,7 @@
<dependency>
<groupId>org.scala-lang.modules</groupId>
<artifactId>scala-xml_${scala.binary.version}</artifactId>
- <version>1.2.0</version>
+ <version>2.1.0</version>
Review Comment:
try update this due to
<img width="746" alt="image" src="https://user-images.githubusercontent.com/1475305/189395697-379c070a-737c-40af-ae7c-049623d86b67.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org