You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "LouisGariepy (via GitHub)" <gi...@apache.org> on 2023/06/03 06:37:08 UTC

[GitHub] [arrow-datafusion] LouisGariepy opened a new pull request, #6538: Remove `avro_to_arrow::reader::Reader::next` in favor of `Iterator` implementation.

LouisGariepy opened a new pull request, #6538:
URL: https://github.com/apache/arrow-datafusion/pull/6538

   # Which issue does this PR close?
   
   Closes #6537.
   
   # Rationale for this change
   Explained in the linked issue
   
   # What changes are included in this PR?
   Reworked `AvroArrowArrayReader::next_batch`, removed `avro_to_arrow::reader::Reader::next`, and reworked `avro_to_arrow::reader::Reader`'s `Iterator` implementation.
   
   # Are these changes tested?
   No change in behavior, so existing tests should be sufficient.
   
   # Are there any user-facing changes?
   I think so? I'm not sure because `avro_to_arrow::reader::Reader` doesn't appear in the documentation, but it's public AFAICT?
   
   Anyways, if `Reader` is indeed public, then users will have to import the `Iterator` trait to use the `next` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6538: Remove `avro_to_arrow::reader::Reader::next` in favor of `Iterator` implementation.

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb commented on PR #6538:
URL: https://github.com/apache/arrow-datafusion/pull/6538#issuecomment-1574865247

   I agree that while this is technically an API change I think the impact will be minimal at best


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6538: Remove `avro_to_arrow::reader::Reader::next` in favor of `Iterator` implementation.

Posted by "alamb (via GitHub)" <gi...@apache.org>.

alamb merged PR #6538:
URL: https://github.com/apache/arrow-datafusion/pull/6538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org