[GitHub] [calcite] rubenada commented on a diff in pull request #3185: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

["rubenada (via GitHub)" <gi...@apache.org>]

rubenada commented on code in PR #3185:
URL: https://github.com/apache/calcite/pull/3185#discussion_r1217947581


##########
core/src/main/java/org/apache/calcite/plan/RelOptPlanner.java:
##########
@@ -350,4 +350,49 @@ public CannotPlanException(String message) {
       super(message);
     }
   }
+
+  /**
+   * Converts a relation expression to a given set of traits, if it does not

Review Comment:
   @zabetak  I've created a new PR (https://github.com/apache/calcite/pull/3243) with the idea of new RelOptRule#convert with an additional planner parameter, which perhaps is the most pragmatic and less disruptive solution to correct this problem, wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org