[GitHub] [incubator-iceberg] rominparekh commented on a change in pull request #117: Pick Largest Bin at Task Planning

[GitBox <gi...@apache.org>]

rominparekh commented on a change in pull request #117: Pick Largest Bin at Task Planning
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r266734481
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
 ##########
 @@ -33,20 +33,22 @@
   public static class ListPacker<T> {
     private final long targetWeight;
     private final int lookback;
+    private final boolean expensiveTaskFirst;
 
-    public ListPacker(long targetWeight, int lookback) {
+    public ListPacker(long targetWeight, int lookback, boolean expensiveTaskFirst) {
       this.targetWeight = targetWeight;
       this.lookback = lookback;
+      this.expensiveTaskFirst = expensiveTaskFirst;
 
 Review comment:
   @prodeezy I like your suggestion. But I think it should be kept outside of this PR because it might involve changes on how we insert bins. Do you think if that's acceptable or do you want me to fold it into this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org