You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "chempin (via GitHub)" <gi...@apache.org> on 2023/02/27 06:13:43 UTC
[GitHub] [dolphinscheduler] chempin opened a new issue, #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
chempin opened a new issue, #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
A process execute with "serial wait" policy and faild with retry times. When process is in the retry interval , try to stop the process instance. The process instance state will be changed to ready stop and never changed to stop.
### What you expected to happen
Make sure every process instance could be stop.
### How to reproduce
1、 create a new process instance and execute it with "serial wait" policy and set retry times >0
2、make sure process instance will be failed, and stop process instance befroe it retry
3、process instance state will be ready stop and never changed to stop.
### Anything else
public class WorkflowStateEventHandler implements StateEventHandler {
private static final Logger logger = LoggerFactory.getLogger(WorkflowStateEventHandler.class);
@Override
public boolean handleStateEvent(WorkflowExecuteRunnable workflowExecuteRunnable,
StateEvent stateEvent) throws StateEventHandleException {
WorkflowStateEvent workflowStateEvent = (WorkflowStateEvent) stateEvent;
measureProcessState(workflowStateEvent);
ProcessInstance processInstance = workflowExecuteRunnable.getProcessInstance();
ProcessDefinition processDefinition = processInstance.getProcessDefinition();
logger.info(
"Handle workflow instance state event, the current workflow instance state {} will be changed to {}",
processInstance.getState(), workflowStateEvent.getStatus());
if (workflowStateEvent.getStatus().isStop()) {
// serial wait execution type needs to wake up the waiting process
if (processDefinition.getExecutionType().typeIsSerialWait() || processDefinition.getExecutionType()
.typeIsSerialPriority()) {
workflowExecuteRunnable.endProcess();
// return true;
}
workflowExecuteRunnable.updateProcessInstanceState(workflowStateEvent);
return true;
}
if (workflowExecuteRunnable.processComplementData()) {
return true;
}
if (workflowStateEvent.getStatus().isFinished()) {
workflowExecuteRunnable.endProcess();
}
if (processInstance.getState().isReadyStop()) {
workflowExecuteRunnable.killAllTasks();
}
return true;
}
I have try to delete this return, and problem fixed
### Version
3.1.x
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version [dolphinscheduler]
Posted by "Kinsonx (via GitHub)" <gi...@apache.org>.
Kinsonx commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-3264458273
> I commented out the ”// return true;“ line，as you can see in the ”Anything else“ part，and the problem fixed， but I'm not sure if it will introduce other problems.
it does work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version [dolphinscheduler]
Posted by "Pandas886 (via GitHub)" <gi...@apache.org>.
Pandas886 commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-2210877098
> I commented out the ”// return true;“ line，as you can see in the ”Anything else“ part，and the problem fixed， but I'm not sure if it will introduce other problems.
解决了吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version [dolphinscheduler]
Posted by "Pandas886 (via GitHub)" <gi...@apache.org>.
Pandas886 commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-2210876070
> I commented out the ”// return true;“ line，as you can see in the ”Anything else“ part，and the problem fixed， but I'm not sure if it will introduce other problems.我注释掉了“// return true;”这一行，正如你在“还有其他什么”部分看到的，问题已经解决，但我不确定这会不会引入其他问题。
这个方法有用吗，可以解决吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version [dolphinscheduler]
Posted by "Kinsonx (via GitHub)" <gi...@apache.org>.
Kinsonx commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-3264346384
version 3.1.9
steps to reproduce
1、 create a new process with two tasks, make sure first task will be failed and set retry times >0
2、execute this process until the first task failed, stop the process instance before it retrys
3、process instance state will be ready stop and never changed to stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ljjjjjjjjjjjjjjjjjjjjj commented on issue #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
Posted by "ljjjjjjjjjjjjjjjjjjjjj (via GitHub)" <gi...@apache.org>.
ljjjjjjjjjjjjjjjjjjjjj commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-1471499934
I commented out the ”// return true;“ line，as you can see in the ”Anything else“ part，and the problem fixed， but I'm not sure if it will introduce other problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dalaopo commented on issue #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
Posted by "dalaopo (via GitHub)" <gi...@apache.org>.
dalaopo commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-1656702069
我们也遇到了相同的问题，这个有临时的解决方案吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version [dolphinscheduler]
Posted by "Kinsonx (via GitHub)" <gi...@apache.org>.
Kinsonx commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-3264310142
Hive the same problem recently， any solutions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lihjChina commented on issue #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
Posted by "lihjChina (via GitHub)" <gi...@apache.org>.
lihjChina commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-1447758763
It also exists in version 3.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
URL: https://github.com/apache/dolphinscheduler/issues/13635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-1445769614
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Sky-Gu commented on issue #13635: [Bug] [ready stop] process instance state is ready stop and never changed to stop. 3.1.3version
Posted by "Sky-Gu (via GitHub)" <gi...@apache.org>.
Sky-Gu commented on issue #13635:
URL: https://github.com/apache/dolphinscheduler/issues/13635#issuecomment-1463077099
I have the same problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org