[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3813: Restrict DictionaryArray to ArrowDictionaryKeyType

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3813:
URL: https://github.com/apache/arrow-rs/pull/3813#discussion_r1127764073


##########
arrow-array/src/array/dictionary_array.rs:
##########
@@ -955,14 +955,6 @@ mod tests {
         DictionaryArray::<Int32Type>::try_new(&keys, &values).unwrap();
     }
 
-    #[test]
-    #[should_panic(expected = "Dictionary key type must be integer, but was Float32")]
-    fn test_try_wrong_dictionary_key_type() {

Review Comment:
   This now results in a compilation error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org