You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2017/08/01 16:00:12 UTC
[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/204
Fix wrong indentation in Windows Azure ARM config
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs windows-azure-arm-identation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit e0ab53222b99a4611c1fb2f5c66889e5e25c510c
Author: Valentin Aitken <bo...@gmail.com>
Date: 2017-08-01T15:59:42Z
Fix wrong indentation in Windows Azure ARM config
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/204#discussion_r130730297
--- Diff: guide/locations/_azure-ARM.md ---
@@ -158,9 +158,8 @@ brooklyn.catalog:
destroyOnFailure: false
templateOptions:
- overrideLoginUser: brooklyn
- overrideLoginPassword: "secretPass1!"
- resourceGroup: <ResourceGroup-name>
--- End diff --
Yes, for Linux Azure ARM locations Apache Brooklyn docs does not advice to use a specific `resourceGroup`. I do not see a reason why we should advice users to use fixed resourceGroup.
I tested without this parameter and it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs issue #204: Fix wrong indentation in Windows Azure ARM config
Posted by ygy <gi...@git.apache.org>.
Github user ygy commented on the issue:
https://github.com/apache/brooklyn-docs/pull/204
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/204#discussion_r130656924
--- Diff: guide/locations/_azure-ARM.md ---
@@ -158,9 +158,8 @@ brooklyn.catalog:
destroyOnFailure: false
templateOptions:
- overrideLoginUser: brooklyn
- overrideLoginPassword: "secretPass1!"
- resourceGroup: <ResourceGroup-name>
--- End diff --
Did you mean to remove this line @bostko?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---