You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2025/12/11 14:03:50 UTC
Re: [PR] [fix][broker] PIP-442: Fix race condition in async semaphore permit updates that causes memory limits to become ineffective [pulsar]
codecov-commenter commented on PR #25066:
URL: https://github.com/apache/pulsar/pull/25066#issuecomment-3642084381
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/25066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `4 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 74.28%. Comparing base ([`4e5364f`](https://app.codecov.io/gh/apache/pulsar/commit/4e5364fa7e5ffb6b834231737165253e6f8377e7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83c91c7`](https://app.codecov.io/gh/apache/pulsar/commit/83c91c7bbdf385326decd75c1b6917e0f92f0509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/25066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/pulsar/common/semaphore/AsyncSemaphoreImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&filepath=pulsar-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Fsemaphore%2FAsyncSemaphoreImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9zZW1hcGhvcmUvQXN5bmNTZW1hcGhvcmVJbXBsLmphdmE=) | 82.35% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/pulsar/proxy/server/LookupProxyHandler.java](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&filepath=pulsar-proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fproxy%2Fserver%2FLookupProxyHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL0xvb2t1cFByb3h5SGFuZGxlci5qYXZh) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #25066 +/- ##
============================================
- Coverage 74.49% 74.28% -0.22%
+ Complexity 34210 34111 -99
============================================
Files 1921 1921
Lines 150417 150412 -5
Branches 17470 17473 +3
============================================
- Hits 112059 111738 -321
- Misses 29478 29764 +286
- Partials 8880 8910 +30
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/25066/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/25066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.32% <0.00%> (-0.26%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/25066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.83% <54.54%> (-0.10%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/25066/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.83% <81.81%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/25066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/pulsar/broker/service/ServerCnx.java](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&filepath=pulsar-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fbroker%2Fservice%2FServerCnx.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NlcnZlckNueC5qYXZh) | `71.71% <100.00%> (+0.27%)` | :arrow_up: |
| [...apache/pulsar/proxy/server/LookupProxyHandler.java](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&filepath=pulsar-proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fproxy%2Fserver%2FLookupProxyHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLXByb3h5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvcHJveHkvc2VydmVyL0xvb2t1cFByb3h5SGFuZGxlci5qYXZh) | `58.08% <66.66%> (-0.37%)` | :arrow_down: |
| [...he/pulsar/common/semaphore/AsyncSemaphoreImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/25066?src=pr&el=tree&filepath=pulsar-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Fsemaphore%2FAsyncSemaphoreImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9zZW1hcGhvcmUvQXN5bmNTZW1hcGhvcmVJbXBsLmphdmE=) | `91.83% <82.35%> (-0.27%)` | :arrow_down: |
... and [92 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/25066/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org