[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests

[Tibor17 <gi...@git.apache.org>]

Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/167
  
    You completely changed code style.
    Please use ASF Maven code style because here I do not see relevant changes.
    
    On Wed, Oct 11, 2017 at 5:52 PM, DaGeRe <no...@github.com> wrote:
    
    > Currently, surefire creates a new byte array with size of the input *3 for
    > saving the unescaped input. This made surefire way slower than running a
    > test directly in eclipse or with gradle, if it used standardout or error
    > heavily.
    > By using a list for saving the elements and converting them to an array
    > afterwards, this problem is solved, and stdout-heavy surefire tests get
    > faster.
    > ------------------------------
    > You can view, comment on, or merge this pull request online at:
    >
    >   https://github.com/apache/maven-surefire/pull/167
    > Commit Summary
    >
    >    - Before, surefire created a new byte array with size of the input *3
    >    for saving the unescaped input. This made
    >
    > File Changes
    >
    >    - *M* surefire-api/src/main/java/org/apache/maven/surefire/
    >    booter/ForkingRunListener.java
    >    <https://github.com/apache/maven-surefire/pull/167/files#diff-0> (278)
    >    - *M* surefire-api/src/main/java/org/apache/maven/surefire/
    >    util/internal/StringUtils.java
    >    <https://github.com/apache/maven-surefire/pull/167/files#diff-1> (327)
    >    - *M* surefire-api/src/test/java/org/apache/maven/surefire/
    >    util/internal/StringUtilsTest.java
    >    <https://github.com/apache/maven-surefire/pull/167/files#diff-2> (84)
    >
    > Patch Links:
    >
    >    - https://github.com/apache/maven-surefire/pull/167.patch
    >    - https://github.com/apache/maven-surefire/pull/167.diff
    >
    > —
    > You are receiving this because you are subscribed to this thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/maven-surefire/pull/167>, or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AA_yR0DXigfKgA6fHyskr2on3rlGN3Jjks5srOREgaJpZM4P1tru>
    > .
    >
    
    
    
    -- 
    Cheers
    Tibor



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org