You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/26 20:30:47 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #12436: [BEAM-9891] TPC-DS module initialization, tables and queries stored

kennknowles commented on a change in pull request #12436:
URL: https://github.com/apache/beam/pull/12436#discussion_r477570754



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/schema/BeamTableUtils.java
##########
@@ -151,10 +151,16 @@ public static Object autoCastField(Schema.Field field, Object rawObj) {
         case INT32:
           return Integer.valueOf(raw);
         case INT64:
+          if (raw.equals("")) {
+            return null;

Review comment:
       Just curious about this. Is this because `autoCastField` is how CSV is converted to INT64? I happen to be looking at other things and found this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org