You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/11 18:53:52 UTC
[GitHub] [superset] justinpark opened a new pull request, #21771: fix(sqllab): remove set state on component update lifecycle
justinpark opened a new pull request, #21771:
URL: https://github.com/apache/superset/pull/21771
### SUMMARY
Since the legacy TabbedSqlEditor component uses `UNSAFE_componentWillReceiveProps` lifecycle method to update the state for `editorQueries` and `dataPreviewQueries`, which **only** consumes in the result panel.
This can also violate the maximum update depth exceeded in some point.
This commit deprecates `UNSAFE_componentWillReceiveProps` implementation and moves to the SouthPane connector where it actually needs.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="715" alt="Screen Shot 2022-10-11 at 11 00 46 AM" src="https://user-images.githubusercontent.com/1392866/195172412-44f5ee8a-5fc7-4515-9e3e-0bdf84155c8f.png">
<img width="874" alt="Screen Shot 2022-10-10 at 4 34 19 PM" src="https://user-images.githubusercontent.com/1392866/195174797-a630d588-087c-4e66-a885-c364169d8a2b.png">
After:
No errors
### TESTING INSTRUCTIONS
N/A
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
cc: @ktmud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21771: fix(sqllab): remove set state on component update lifecycle
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21771:
URL: https://github.com/apache/superset/pull/21771#issuecomment-1286826530
LGTM! Can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #21771: fix(sqllab): remove set state on component update lifecycle
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #21771:
URL: https://github.com/apache/superset/pull/21771#issuecomment-1281316646
> Can you add more details on how to reproduce this max-depth-call-stack error?
@ktmud I updated the step to reproduce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21771: fix(sqllab): remove set state on component update lifecycle
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21771:
URL: https://github.com/apache/superset/pull/21771#issuecomment-1275195734
# [Codecov](https://codecov.io/gh/apache/superset/pull/21771?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21771](https://codecov.io/gh/apache/superset/pull/21771?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (640a69a) into [master](https://codecov.io/gh/apache/superset/commit/d7ee443a134f88aa7fff8d2d038b50c94fb039e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7ee443) will **increase** coverage by `0.02%`.
> The diff coverage is `32.50%`.
> :exclamation: Current head 640a69a differs from pull request most recent head 53dede9. Consider uploading reports for the commit 53dede9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21771 +/- ##
==========================================
+ Coverage 66.85% 66.88% +0.02%
==========================================
Files 1800 1802 +2
Lines 68967 68980 +13
Branches 7339 7342 +3
==========================================
+ Hits 46107 46134 +27
+ Misses 20968 20950 -18
- Partials 1892 1896 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.22% <41.37%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...frontend/src/SqlLab/components/SouthPane/index.tsx](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS9pbmRleC50c3g=) | `72.72% <ø> (+6.06%)` | :arrow_up: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `55.73% <ø> (ø)` | |
| [...d/src/SqlLab/components/TabbedSqlEditors/index.jsx](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMvaW5kZXguanN4) | `49.03% <ø> (-5.67%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `55.04% <ø> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.tsx](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLnRzeA==) | `88.88% <ø> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `80.15% <ø> (ø)` | |
| [...tend/src/utils/isDashboardVirtualizationEnabled.ts](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2lzRGFzaGJvYXJkVmlydHVhbGl6YXRpb25FbmFibGVkLnRz) | `0.00% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.63% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.70% <ø> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/21771/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #21771: fix(sqllab): remove set state on component update lifecycle
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #21771:
URL: https://github.com/apache/superset/pull/21771#issuecomment-1275153001
Can you add more details on how to reproduce this max-depth-call-stack error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #21771: fix(sqllab): remove set state on component update lifecycle
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #21771:
URL: https://github.com/apache/superset/pull/21771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org